[ 
https://issues.apache.org/jira/browse/LUCENE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114165#comment-13114165
 ] 

Shai Erera commented on LUCENE-3454:
------------------------------------

I personally find optimize() clear, and people got used to it already. However 
I do agree it sounds like it's doing magic, but really it just merges segments.

We already have maybeMerge(), how about consolidating the two under 
merge(MergeLevel) where MergeLevel is either AGGRESSIVE (optimize) or DELICATE 
(maybeMerge)? Or something in that spirit.

Anyway, if we end up renaming, we should probably rename 
MergePolicy.findSegmentsForOptimize as well. If we consolidate, we should 
consolidate it as well.

> rename optimize to a less cool-sounding name
> --------------------------------------------
>
>                 Key: LUCENE-3454
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3454
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> I think users see the name optimize and feel they must do this, because who 
> wants a suboptimal system? but this probably just results in wasted time and 
> resources.
> maybe rename to collapseSegments or something?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to