[
https://issues.apache.org/jira/browse/LUCENE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114323#comment-13114323
]
Michael McCandless commented on LUCENE-3454:
--------------------------------------------
bq. Why do we have IR.reopen and not maybeReopen?
That's a good point... and I actually don't like that naming either!!
I think it trips users up because of it's hidden maybe-ness, ie, users who
always close the old reader on calling this API (which, if no reopen actually
occurred, closes the very same reader it had just returned).
Also, IW already has a merge method, taking a OneMerge parameter; that naming I
think is correct because it's unconditional: IW will carry out the merge you
passed to it.
Naming is the hardest part!
> rename optimize to a less cool-sounding name
> --------------------------------------------
>
> Key: LUCENE-3454
> URL: https://issues.apache.org/jira/browse/LUCENE-3454
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Robert Muir
>
> I think users see the name optimize and feel they must do this, because who
> wants a suboptimal system? but this probably just results in wasted time and
> resources.
> maybe rename to collapseSegments or something?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
