I think for PR 420 (https://github.com/apache/lucene/pull/420) we are (confusingly!) not really seeing performance benefits -- taxonomy index got a bit bigger, and loading the parent arrays no faster? So Patrick closed that one.
But the other PR (https://github.com/apache/lucene/pull/264) looks like it shows huge speedups on luceneutil. Thanks Greg for pushing on this one! Mike McCandless http://blog.mikemccandless.com On Mon, Nov 15, 2021 at 12:22 PM Adrien Grand <jpou...@gmail.com> wrote: > Thanks Greg! > > On Mon, Nov 15, 2021 at 6:09 PM Greg Miller <gsmil...@gmail.com> wrote: > >> +1, yeah let's see if we can get these in. It would be nice to not >> carry the back-compat logic into 10. I'll prioritize these >> today/tomorrow; I think we should be able to turn them around pretty >> quickly. I'll update on this thread when PRs have been merged. >> >> Cheers, >> -Greg >> >> On Mon, Nov 15, 2021 at 6:20 AM Adrien Grand <jpou...@gmail.com> wrote: >> > >> > Thanks Dawid. >> > >> > @Greg Miller What do you think about getting these two PRs in for 9.0? >> > >> > On Sun, Nov 14, 2021 at 9:25 AM Dawid Weiss <dawid.we...@gmail.com> >> wrote: >> >> >> >> I think we should wait for these two changes. >> >> >> >> I also think we should add automatic bundle names to all JARs starting >> >> with 9.0. Even if they're not proper modules yet, it'd clarify what >> >> the module names would be for all of the 9x line. I think a short name >> >> of lucene.* is sufficient (we don't need to prefix with >> >> org.apache.lucene) so that we have modules like lucene.core, >> >> lucene.analysis.kuromoji, etc. I can add this - already have a local >> >> patch that does it and enables Luke to become a first-class module, >> >> for example. >> >> >> >> Dawid >> >> >> >> On Sat, Nov 13, 2021 at 8:49 PM Adrien Grand <jpou...@gmail.com> >> wrote: >> >> > >> >> > Hello, >> >> > >> >> > I plan to build a RC for Lucene 9.0 in the next few days. >> >> > >> >> > We don't have blockers left, but there are two faceting changes that >> look like we could save some backward compatibility logic in 10.x by >> folding them into 9.0: >> >> > - LUCENE-10062: https://github.com/apache/lucene/pull/264 >> >> > - LUCENE-10122: https://github.com/apache/lucene/pull/420 >> >> > >> >> > I'm interested in thoughts regarding whether I should wait for these >> changes. >> >> > >> >> > -- >> >> > Adrien >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> >> > >> > >> > -- >> > Adrien >> > > > -- > Adrien >
