Can we also push commit to branch 9x (just don't want it to get forgotten) On Fri, Nov 19, 2021 at 10:50 AM Adrien Grand <jpou...@gmail.com> wrote: > > Thanks Greg, Patrick, Mike and Robert for the quick turnaround on > getting these changes merged! I'll now resume work on the 9.0 release. > > On Fri, Nov 19, 2021 at 4:44 PM Greg Miller <gsmil...@gmail.com> wrote: > > > > Heads up that both LUCENE-10122 and LUCENE-10062 have been merged onto > > branch_9_0 now. @Adrien Grand I know you're aware already, but > > following up here just for completeness. Thanks! > > > > -Greg > > > > On Mon, Nov 15, 2021 at 11:17 AM Robert Muir <rcm...@gmail.com> wrote: > > > > > > On Mon, Nov 15, 2021 at 2:02 PM Michael McCandless > > > <luc...@mikemccandless.com> wrote: > > > > > > > > > > > > Yeah I love that idea, but that's not what Patrick's PR explored (yet?). > > > > > > > > His explored switching away from custom token positions to > > > > NumericDocValues to store the same data (ordinal -> parent mapping), > > > > but it still loaded all of those into massive heap-resident int[]. > > > > > > > > I agree it would be awesome to try avoiding those big int[] and reading > > > > live from NumericDocValues during faceting! It would require some > > > > re-work of the facetting code to e.g. sort the ordinals to > > > > (efficiently) visiting them in forward iterator-friendly order. > > > > > > > > But that is a different change and probably we should not hold 9.0 for > > > > it? > > > > > > > > > > Agreed: I was confused about the scope of the change. > > > > -- > Adrien
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
