+1 Thanks Tomoko. On Fri, Nov 26, 2021 at 10:51 AM Tomoko Uchida <[email protected]> wrote:
> Hi, > > I think all Luke-related blockers or issues were resolved. Other minor > issues that come from (partially) adopting the module system could pop up, > they will be handled in future releases. > > Thanks, > Tomoko > > > 2021年11月26日(金) 2:29 Adrien Grand <[email protected]>: > >> Sorry Tomoko I'm just seeing your message now. Please go ahead and >> backport to branch_9_0. >> >> On Thu, Nov 25, 2021 at 12:41 PM Tomoko Uchida < >> [email protected]> wrote: >> >>> > On LUCENE-10255, there's a reference to issues with the Luke Analysis >>> > UI, is it something we can fix as well for RC3? >>> >>> Rather than making the old UI work with the module system, I would >>> remove it (at least for now). >>> https://github.com/apache/lucene/pull/475 >>> >>> Could I backport it to branch_9_0? >>> >>> Tomoko >>> >>> >>> 2021年11月25日(木) 3:46 Uwe Schindler <[email protected]>: >>> >>>> See: https://issues.apache.org/jira/browse/LUCENE-10260 >>>> >>>> >>>> >>>> ----- >>>> >>>> Uwe Schindler >>>> >>>> Achterdiek 19, D-28357 Bremen >>>> >>>> https://www.thetaphi.de >>>> >>>> eMail: [email protected] >>>> >>>> >>>> >>>> *From:* Uwe Schindler <[email protected]> >>>> *Sent:* Wednesday, November 24, 2021 7:44 PM >>>> *To:* [email protected] >>>> *Subject:* RE: [VOTE] Release Lucene 9.0.0 RC2 >>>> >>>> >>>> >>>> I found another bug in Luke: >>>> >>>> >>>> >>>> Implementation version no longer shows. May have to do with this class >>>> LuceneVersion no longer getting Implementation-Version from the module JAR. >>>> >>>> >>>> >>>> This is not serious, but would be good to fix in a respin. Will open >>>> issue. >>>> >>>> >>>> >>>> ----- >>>> >>>> Uwe Schindler >>>> >>>> Achterdiek 19, D-28357 Bremen >>>> >>>> https://www.thetaphi.de >>>> >>>> eMail: [email protected] >>>> >>>> >>>> >>>> > -----Original Message----- >>>> >>>> > From: Uwe Schindler <[email protected]> >>>> >>>> > Sent: Wednesday, November 24, 2021 7:00 PM >>>> >>>> > To: [email protected] >>>> >>>> > Subject: RE: [VOTE] Release Lucene 9.0.0 RC2 >>>> >>>> > >>>> >>>> > Hi, >>>> >>>> > >>>> >>>> > although the smoke teste succeeded by Jenkins: >>>> >>>> > https://jenkins.thetaphi.de/job/Lucene-Release-Tester/6/console >>>> >>>> > >>>> >>>> > ...my manual review ran into problems: >>>> >>>> > - Luke did not start for me, see >>>> https://issues.apache.org/jira/browse/LUCENE- >>>> <https://issues.apache.org/jira/browse/LUCENE-10259> >>>> >>>> > 10259 <https://issues.apache.org/jira/browse/LUCENE-10259> (fix is >>>> easy, just quotes missing in shell scripts). Because on Windows it >>>> >>>> > uses "javaw" and not "java", you don’t even see an error message >>>> which is >>>> >>>> > fatal! >>>> >>>> > >>>> >>>> > So -1 to release (sorry, we need a test with whitespace, e.g. >>>> smoketester should >>>> >>>> > check this, but starting luke is hard inside smoker). >>>> >>>> > >>>> >>>> > What looks fine: >>>> >>>> > - Javadocs are very nice the home page of docs folder looks fine >>>> >>>> > - Licenses are OK >>>> >>>> > - The three folders with JAR files are good, very easy to understand. >>>> >>>> > >>>> >>>> > Home dir is also good. >>>> >>>> > >>>> >>>> > I did not do a real project with Maven, because I have no pure-lucene >>>> one >>>> >>>> > available. I would need solr-9.0.0, too 😊 >>>> >>>> > >>>> >>>> > Uwe >>>> >>>> > >>>> >>>> > ----- >>>> >>>> > Uwe Schindler >>>> >>>> > Achterdiek 19, D-28357 Bremen >>>> >>>> > https://www.thetaphi.de >>>> >>>> > eMail: [email protected] >>>> >>>> > >>>> >>>> > > -----Original Message----- >>>> >>>> > > From: Adrien Grand <[email protected]> >>>> >>>> > > Sent: Tuesday, November 23, 2021 9:40 AM >>>> >>>> > > To: Lucene Dev <[email protected]> >>>> >>>> > > Subject: [VOTE] Release Lucene 9.0.0 RC2 >>>> >>>> > > >>>> >>>> > > Please vote for release candidate 2 for Lucene 9.0.0 >>>> >>>> > > >>>> >>>> > > The artifacts can be downloaded from: >>>> >>>> > > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC2-rev- >>>> >>>> > > 95072f3b71e67e308d71a6149323bf7dd04c8f75 >>>> >>>> > > >>>> >>>> > > You can run the smoke tester directly with this command: >>>> >>>> > > >>>> >>>> > > python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>> >>>> > > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC2-rev- >>>> >>>> > > 95072f3b71e67e308d71a6149323bf7dd04c8f75 >>>> >>>> > > >>>> >>>> > > The vote will be open until 2021-11-26 09:00 UTC. >>>> >>>> > > >>>> >>>> > > [ ] +1 approve >>>> >>>> > > [ ] +0 no opinion >>>> >>>> > > [ ] -1 disapprove (and reason why) >>>> >>>> > > >>>> >>>> > > Here is my +1 >>>> >>>> > > >>>> >>>> > > -- >>>> >>>> > > Adrien >>>> >>>> > > >>>> >>>> > > >>>> --------------------------------------------------------------------- >>>> >>>> > > To unsubscribe, e-mail: [email protected] >>>> >>>> > > For additional commands, e-mail: [email protected] >>>> >>>> > >>>> >>>> > >>>> >>>> > --------------------------------------------------------------------- >>>> >>>> > To unsubscribe, e-mail: [email protected] >>>> >>>> > For additional commands, e-mail: [email protected] >>>> >>> >> >> -- >> Adrien >> > -- Adrien
