I confirmed that the Lucene-Check-main job now passes: https://builds.apache.org/job/Lucene/job/Lucene-Check-main/.
On Thu, Jan 6, 2022 at 2:49 PM Dawid Weiss <[email protected]> wrote: > > > > And then another "private one" next to it. The Github-supplied one should > > include a local one. > > I'd love such a solution too. But there is no way to do it, as far as I know > - these properties are read early on (they determine jvm settings). Also, > these settings do depend on the local environment so there's no one-fits-all > setup. I typically work around this problem in CI jobs by running gradlew > help first, followed by the actual task. github workflows are set up this way. > > D. > > Dawid > > On Thu, Jan 6, 2022 at 2:35 PM Uwe Schindler <[email protected]> wrote: >> >> Hi Adrien, >> >> all is setup. I copied an example file over and just added the jvm/worker >> props and gradle daemon shit. Actually the gradle.properties stuff is a bit >> shitty to handle in CI environments, as you always have to workaround some >> shortcomings of gradle. >> >> I'd prefer to have some local copy always available in checkout folder >> that’s also updated by git pull. And then another "private one" next to it. >> The Github-supplied one should include a local one. With Ant this was muc >> better as it was inside build.xml logic and we were able to customize it. >> Here it only loads 3 places and those in some un-intuitive order. >> >> Nevertheless, jobs are back enabled and you can merge. >> >> Uwe >> >> ----- >> Uwe Schindler >> Achterdiek 19, D-28357 Bremen >> https://www.thetaphi.de >> eMail: [email protected] >> >> > -----Original Message----- >> > From: Adrien Grand <[email protected]> >> > Sent: Thursday, January 6, 2022 1:40 PM >> > To: Lucene Dev <[email protected]> >> > Subject: Re: Heads up: main branch will soon require Java 17 >> > >> > Hi Uwe, >> > >> > There is no hurry to merge the pull request, so feel free to go back >> > to JDK 11 on Policeman Jenkins and I'll merge the PR when everything >> > is ready. >> > >> > On Thu, Jan 6, 2022 at 12:08 PM Uwe Schindler <[email protected]> wrote: >> > > >> > > I think I know: On Policeman Jenkins it starts with clean checkout always >> > (same on ASF Jenkins), but ASF Jenkins places the config file template >> > after >> > checkout. So there's no gradle.properties file. On policeman, I have to >> > replicate >> > the full file into the global jenkins one. An alternative is to run >> > jenkins 2 times: >> > Once before main job just to create the file and then execute full build. >> > > >> > > Will do in afternoon, it's disabled until then. >> > > Uwe >> > > >> > > ----- >> > > Uwe Schindler >> > > Achterdiek 19, D-28357 Bremen >> > > https://www.thetaphi.de >> > > eMail: [email protected] >> > > >> > > > -----Original Message----- >> > > > From: Uwe Schindler <[email protected]> >> > > > Sent: Thursday, January 6, 2022 11:58 AM >> > > > To: [email protected] >> > > > Subject: RE: Heads up: main branch will soon require Java 17 >> > > > >> > > > Hi, >> > > > >> > > > it still fails with Policeman Jenkins and I think we can't easily fix >> > > > this until >> > we >> > > > patch the build file, too: >> > > > >> > > > Policeman Jenkins uses the feature of RUNTIME_JAVA_HOME. If that is >> > > > enabled, javac will be forked and runs as a separate process. And this >> > separate >> > > > process seems to not get the gradle properties. But I am not fully >> > > > sure about >> > > > that because I have no idea how Spotless works. >> > > > >> > > > I have to try to reproduce this locally to understand why this is >> > > > happening. >> > > > >> > > > I am out of office now, so I disabled Policeman Jenkins builds until I >> > > > can >> > check >> > > > this. >> > > > >> > > > Uwe >> > > > >> > > > ----- >> > > > Uwe Schindler >> > > > Achterdiek 19, D-28357 Bremen >> > > > https://www.thetaphi.de >> > > > eMail: [email protected] >> > > > >> > > > > -----Original Message----- >> > > > > From: Uwe Schindler <[email protected]> >> > > > > Sent: Thursday, January 6, 2022 11:44 AM >> > > > > To: [email protected] >> > > > > Subject: RE: Heads up: main branch will soon require Java 17 >> > > > > >> > > > > Hi, >> > > > > >> > > > > On my jenkins all nodes had a local gradle.properties file in their >> > > > > home >> > > > > directory to setup node-specific values. As Gradle searches for all >> > > > > those >> > files >> > > > > and applies them, the node-specific ones now only have the daemon >> > disable >> > > > > and the number of workers. Everything else I removed. >> > > > > >> > > > > So it will now read the user one and then the build-dir local one. >> > > > > >> > > > > Uwe >> > > > > >> > > > > ----- >> > > > > Uwe Schindler >> > > > > Achterdiek 19, D-28357 Bremen >> > > > > https://www.thetaphi.de >> > > > > eMail: [email protected] >> > > > > >> > > > > > -----Original Message----- >> > > > > > From: Adrien Grand <[email protected]> >> > > > > > Sent: Thursday, January 6, 2022 11:33 AM >> > > > > > To: Lucene Dev <[email protected]> >> > > > > > Subject: Re: Heads up: main branch will soon require Java 17 >> > > > > > >> > > > > > I just updated the gradle.properties file under "Config files" to >> > > > > > add >> > > > > > the module exports to JVM args, the next build should pass. >> > > > > > >> > > > > > On Thu, Jan 6, 2022 at 11:28 AM Adrien Grand <[email protected]> >> > > > wrote: >> > > > > > > >> > > > > > > To clarify, merging the PR wouldn't address the test failures. >> > > > > > > >> > > > > > > On Thu, Jan 6, 2022 at 11:27 AM Adrien Grand <[email protected]> >> > > > > wrote: >> > > > > > > > >> > > > > > > > This seems to be due to the fact that it's using an old >> > > > > > > > gradle.properties file that doesn't have the module exports >> > > > > > > > that >> > Dawid >> > > > > > > > added as part of LUCENE-10066. >> > > > > > > > https://github.com/apache/lucene/pull/259/files#diff- >> > > > > > >> > > > > >> > > > >> > fbdfae634c6898f4a415bc2a278ff771c38436d70b0e64250ab068b4b3e58426R >> > > > > > 48-R52 >> > > > > > > > >> > > > > > > > Let me look into whether I can make the ASF Jenkins recreate >> > > > > > > > its >> > > > > > > > gradle.properties. >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > -- >> > > > > > > Adrien >> > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > Adrien >> > > > > > >> > > > > > --------------------------------------------------------------------- >> > > > > > To unsubscribe, e-mail: [email protected] >> > > > > > For additional commands, e-mail: [email protected] >> > > > > >> > > > > >> > > > > --------------------------------------------------------------------- >> > > > > To unsubscribe, e-mail: [email protected] >> > > > > For additional commands, e-mail: [email protected] >> > > > >> > > > >> > > > --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: [email protected] >> > > > For additional commands, e-mail: [email protected] >> > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > >> > >> > -- >> > Adrien >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> -- Adrien --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
