On Tue, May 17, 2022 at 5:59 AM Alan Woodward <romseyg...@gmail.com> wrote: > > It was part of the release process, which runs with Java 11. It should be > fixed now. > > > Newer java versions won't make a broken link, you just won't have a link at > > all. > > This seems a bit of a shame, as some of the problems were genuine API bugs - > public methods with package-private parameter classes, and so on. Do we have > other ways of detecting these? Warning levels on the compiler maybe? >
Agreed, although we are really abusing the functionality. Main purpose of the check is to prevent broken links (HTTP 404 from the website, etc). I don't know of a built-in way to do the exact check. One idea is to add a check to our custom doclet: https://github.com/apache/lucene/blob/main/dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java Element has getModifiers() which should be enough to check the visibility of things like parameters and return type. However, we might have to restructure the checker a bit, for most modules we aren't even descending into "parameter" level checks today: most modules are only enforcing at class level. Honestly it is still probably the wrong tool for this, as the issue really isn't javadocs related. But the doclet is a hammer we can use for checks like this. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
