I think it makes sense to fail the build in both cases. An early warning to upgrade buggy old java releases...
D. On Wed, May 18, 2022 at 9:06 AM Tomoko Uchida <tomoko.uchida.1...@gmail.com> wrote: > > Thanks, Dawid for the pointer. > If there is a distribution-agnostic and reliable minor/patch version, we > could specify a more detailed minimum requirement version for building. > I think we shouldn't limit the distribution - or, we should (at least on > making the release artifact)? > > Tomoko > > > 2022年5月18日(水) 15:12 Dawid Weiss <dawid.we...@gmail.com>: >> >> > I'd agree with this and it'd be great if we can fail to build locally and >> > encourage devs to use a newer patch version of Java (instead of blaming >> > developers for not upgrading jdk they use) - I have no good idea at all >> > though. >> >> This should be simple. In alternative-jdk-support.gradle, check >> whether jvmCurrent's JvmInstallationMetadata is on JDK 11 major and if >> so, verify the minor to be at least at a certain bugfix release? You >> can parse out the minor version using Runtime.Version API [1] from one >> of these (not sure which one gradle extracts): >> >> String getImplementationVersion(); >> String getRuntimeVersion(); >> String getJvmVersion(); >> >> https://docs.oracle.com/javase/9/docs/api/java/lang/Runtime.Version.html >> >> D. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
