OK - well, this vote passed, but we will re-spin to capture the bug
fix and the JDK-19 support. I'll open a new vite thread for RC2
On Mon, Sep 26, 2022 at 9:57 AM Uwe Schindler <u...@thetaphi.de> wrote:
>
> See my mail before. Delete gradle.properties from Lucene checkout folder.
>
> Uwe
>
> Am 26.09.2022 um 15:51 schrieb Michael Sokolov:
> > Hm the build failed with this:
> >
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':lucene:core:compileMain19Java'.
> >> Error while evaluating property 'javaCompiler' of task
> >> ':lucene:core:compileMain19Java'
> > > Failed to calculate the value of task
> > ':lucene:core:compileMain19Java' property 'javaCompiler'.
> > > No compatible toolchains found for request filter:
> > {languageVersion=19, vendor=any, implementation=vendor-specific}
> > (auto-detect true, auto-download false)
> >
> > Does this just mean I need to install JDK19, or is there some problem
> > in our build scripts? If I install will it autodetect??
> >
> > On Mon, Sep 26, 2022 at 9:36 AM Michael Sokolov <msoko...@gmail.com> wrote:
> >> Nice! Thanks everyone, I will refresh and start building the artifacts
> >>
> >> On Mon, Sep 26, 2022 at 9:33 AM Uwe Schindler <u...@thetaphi.de> wrote:
> >>> OK,
> >>>
> >>> Java 19 support for Panama Foreign is in! Thanks for waiting!
> >>>
> >>> Uwe
> >>>
> >>> Am 26.09.2022 um 15:08 schrieb Uwe Schindler:
> >>>
> >>> I will also merge shortly! Please have a quick look @
> >>> https://github.com/apache/lucene/pull/912
> >>>
> >>> That's really great that Eclipse Adoptium released in time :-)
> >>>
> >>> Uwe
> >>>
> >>> Am 26.09.2022 um 14:57 schrieb Adrien Grand:
> >>>
> >>> The change is now on branch_9_4.
> >>>
> >>> On Mon, Sep 26, 2022 at 2:38 PM Adrien Grand <jpou...@gmail.com> wrote:
> >>>> I opened a PR and will backport it to relevant branches shortly:
> >>>> https://github.com/apache/lucene/pull/11818.
> >>>>
> >>>> On Mon, Sep 26, 2022 at 2:26 PM Uwe Schindler <u...@thetaphi.de> wrote:
> >>>>> Hi Michael,
> >>>>>
> >>>>> if you give me an hour or so to add changes. All fine now!
> >>>>>> I will re-spin today. I don't think we should wait any longer for
> >>>>>> AdoptOpenJDK - sorry Uwe; I too would like to be able to mess around
> >>>>>> with the new features in JDK19, but I think it's not a good precedent
> >>>>>> to tie our release schedule to an external project's.
> >>>>> Release was done a minute ago:
> >>>>>
> >>>>> C:\Users\Uwe Schindler\Projects\lucene\lucene>gradlew :lucene:core:jar
> >>>>> Starting a Gradle Daemon (subsequent builds will be faster)
> >>>>> <=============> 100% CONFIGURING [31s]
> >>>>> > Provisioning toolchain adoptopenjdk-19-x64-windows.zip >
> >>>>> adoptopenjdk-19-x64-windows.zip > 24.3 MiB/187.4 MiB downloaded
> >>>>>
> >>>>> So I can update and merge, build succeeds and it provisiones JDK 19
> >>>>> automatically and Gradle runs.
> >>>>>
> >>>>> Uwe
> >>>>>
> >>>>>> On Mon, Sep 26, 2022 at 5:42 AM Adrien Grand <jpou...@gmail.com> wrote:
> >>>>>>> Ignacio made me notice than the new Lucene94FieldInfosFormat did not
> >>>>>>> change the codec name compared to Lucene90FieldInfosFormat:
> >>>>>>> https://github.com/apache/lucene/blob/branch_9_4/lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java#L376.
> >>>>>>>
> >>>>>>> The issue with this is that if you mistakenly open a
> >>>>>>> Lucene90FieldInfos file with the 9.4 codec, then it will tell you
> >>>>>>> that there is a corruption despite the fact that checksums match,
> >>>>>>> instead of pointing out the codec mismatch.
> >>>>>>>
> >>>>>>> I suggest that we respin to address this problem.
> >>>>>>>
> >>>>>>> On Sun, Sep 25, 2022 at 8:24 PM Anshum Gupta <ans...@anshumgupta.net>
> >>>>>>> wrote:
> >>>>>>>> +1 (binding)
> >>>>>>>>
> >>>>>>>> The smoke tests passed.
> >>>>>>>> SUCCESS! [2:49:17.242508]
> >>>>>>>>
> >>>>>>>> On Fri, Sep 23, 2022 at 12:22 PM Patrick Zhai <zhai7...@gmail.com>
> >>>>>>>> wrote:
> >>>>>>>>> (non-binding) +1
> >>>>>>>>>
> >>>>>>>>> SUCCESS! [1:11:00.934249]
> >>>>>>>>>
> >>>>>>>>> On Fri, Sep 23, 2022 at 9:44 AM Vigya Sharma <vigya.w...@gmail.com>
> >>>>>>>>> wrote:
> >>>>>>>>>> The smoke tests passed for me too..
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> (no vote)
> >>>>>>>>>>
> >>>>>>>>>> SUCCESS! [1:12:31.588303]
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On Thu, Sep 22, 2022 at 2:27 AM Ignacio Vera <iver...@gmail.com>
> >>>>>>>>>> wrote:
> >>>>>>>>>>> +1
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> SUCCESS! [0:46:00.508949]
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> On Thu, Sep 22, 2022 at 9:53 AM Adrien Grand <jpou...@gmail.com>
> >>>>>>>>>>> wrote:
> >>>>>>>>>>>> +1 SUCCESS! [0:45:35.275017]
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Wed, Sep 21, 2022 at 9:19 PM Michael McCandless
> >>>>>>>>>>>> <luc...@mikemccandless.com> wrote:
> >>>>>>>>>>>>> +1
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> SUCCESS! [0:27:16.514391]
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Mike McCandless
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> http://blog.mikemccandless.com
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> On Wed, Sep 21, 2022 at 2:32 PM Dawid Weiss
> >>>>>>>>>>>>> <dawid.we...@gmail.com> wrote:
> >>>>>>>>>>>>>> +1.
> >>>>>>>>>>>>>> SUCCESS! [0:53:33.891603]
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Ran the smoketester with both java 11 and 17:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> SUCCESS! [2:41:19.024193]
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> On Tue, Sep 20, 2022 at 10:10 PM Michael Sokolov
> >>>>>>>>>>>>>>> <msoko...@gmail.com> wrote:
> >>>>>>>>>>>>>>>> Please vote for release candidate 1 for Lucene 9.4.0
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> The artifacts can be downloaded from:
> >>>>>>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.0-RC1-rev-f5d0646daa5651f2192282ac85551bca667e34f9
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> You can run the smoke tester directly with this command:
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> python3 -u dev-tools/scripts/smokeTestRelease.py \
> >>>>>>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.0-RC1-rev-f5d0646daa5651f2192282ac85551bca667e34f9
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> The vote will be open for at least 72 hours i.e. until
> >>>>>>>>>>>>>>>> 2022-09-24 02:00 UTC.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> [ ] +1 approve
> >>>>>>>>>>>>>>>> [ ] +0 no opinion
> >>>>>>>>>>>>>>>> [ ] -1 disapprove (and reason why)
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Here is my +1
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> ---------------------------------------------------------------------
> >>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >>>>>>>>>>>>>>>> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> ---------------------------------------------------------------------
> >>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >>>>>>>>>>>>>>> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>> --
> >>>>>>>>>>>> Adrien
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> - Vigya
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Anshum Gupta
> >>>>>>>
> >>>>>>> --
> >>>>>>> Adrien
> >>>>>> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >>>>>> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>>>>>
> >>>>> --
> >>>>> Uwe Schindler
> >>>>> Achterdiek 19, D-28357 Bremen
> >>>>> https://www.thetaphi.de
> >>>>> eMail: u...@thetaphi.de
> >>>>>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >>>>> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>>>>
> >>>>
> >>>> --
> >>>> Adrien
> >>>
> >>>
> >>> --
> >>> Adrien
> >>>
> >>> --
> >>> Uwe Schindler
> >>> Achterdiek 19, D-28357 Bremen
> >>> https://www.thetaphi.de
> >>> eMail: u...@thetaphi.de
> >>>
> >>> --
> >>> Uwe Schindler
> >>> Achterdiek 19, D-28357 Bremen
> >>> https://www.thetaphi.de
> >>> eMail: u...@thetaphi.de
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: dev-h...@lucene.apache.org
> >
> --
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: u...@thetaphi.de
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
