We did a major cleanup to the vector API in 9.5 but there are a few things that still annoy me a bit that are worth fixing in my opinion: - VectorValues, the API for float vectors, still exposes a binaryValue() API. We should remove it and only expose floats in the API? - Byte vectors should be represented as byte[] instead of BytesRef in ByteVectorValues, KnnByteVectorField and KnnByteVectorQuery.
If these two changes are low-hanging fruits, maybe we can fold them in order to avoid pushing another breaking change to the API later on. I'll give it a try later today if none beats me to it. On Mon, Jan 23, 2023 at 11:21 AM Luca Cavanna <l...@elastic.co.invalid> wrote: > Hi all, > I meant to start the release today and I see this PR is not merged yet: > https://github.com/apache/lucene/pull/12029 . Alessandro, do you still > plan on merging it shortly? > > Thanks > Luca > > On Sat, Jan 21, 2023 at 11:41 AM Michael Wechner < > michael.wech...@wyona.com> wrote: > >> I tried to understand the issue described on github, but unfortunately do >> not really understand it. >> >> Can you explain a little more? >> >> Thanks >> >> Michael >> >> >> >> Am 21.01.23 um 11:00 schrieb Alessandro Benedetti: >> >> Hi, >> this would be nice to have in 9.5 : >> https://github.com/apache/lucene/issues/12099 >> >> It's a minor (adding getters to KnnQuery) but can be beneficial in Apache >> Solr as soon as possible. >> Planning to merge in a few hours if no objections. >> -------------------------- >> *Alessandro Benedetti* >> Director @ Sease Ltd. >> *Apache Lucene/Solr Committer* >> *Apache Solr PMC Member* >> >> e-mail: a.benede...@sease.io >> >> >> *Sease* - Information Retrieval Applied >> Consulting | Training | Open Source >> >> Website: Sease.io <http://sease.io/> >> LinkedIn <https://linkedin.com/company/sease-ltd> | Twitter >> <https://twitter.com/seaseltd> | Youtube >> <https://www.youtube.com/channel/UCDx86ZKLYNpI3gzMercM7BQ> | Github >> <https://github.com/seaseltd> >> >> >> On Thu, 19 Jan 2023 at 14:38, Luca Cavanna <l...@elastic.co.invalid> >> <l...@elastic.co.invalid> wrote: >> >>> Thanks Robert for the help with the github milestone. >>> >>> I am planning on cutting the release branch on Monday if there are no >>> objections. >>> >>> Cheers >>> Luca >>> >>> On Tue, Jan 17, 2023 at 7:08 PM Robert Muir <rcm...@gmail.com> wrote: >>> >>>> +1 to release, thank you for volunteering to be RM! >>>> >>>> I went thru 9.5 section of CHANGES.txt and tagged all the GH issues in >>>> there with milestone too, if they didn't already have it. It looks >>>> even bigger now. >>>> >>>> On Fri, Jan 13, 2023 at 4:54 AM Luca Cavanna <java...@apache.org> >>>> wrote: >>>> > >>>> > Hi all, >>>> > I'd like to propose that we release Lucene 9.5.0. There is a decent >>>> amount of changes that would go into it looking at the github milestone: >>>> https://github.com/apache/lucene/milestone/4 . I'd volunteer to be the >>>> release manager. There is one PR open listed for the 9.5 milestone: >>>> https://github.com/apache/lucene/pull/11873 . Is this something that >>>> we do want to address before we release? Is anybody aware of outstanding >>>> work that we would like to include or known blocker issues that are not >>>> listed in the 9.5 milestone? >>>> > >>>> > Cheers >>>> > Luca >>>> > >>>> > >>>> > >>>> > >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>>> For additional commands, e-mail: dev-h...@lucene.apache.org >>>> >>>> >> -- Adrien
