Hi Alessandro, It's ok to merge changes before feature freeze, currently planned for Friday. From a quick look, this is a new feature rather than a bug fix, so if it's not ready by Friday it could wait until the next minor?
On Mon, Jun 12, 2023 at 6:15 PM Alessandro Benedetti <a.benede...@sease.io> wrote: > Hi, > we are finalizing https://github.com/apache/lucene/pull/12253, we got > some last-minute valuable review comments and we would like to apply the > suggestions and bring them in 9.x . > Cheers > -------------------------- > *Alessandro Benedetti* > Director @ Sease Ltd. > *Apache Lucene/Solr Committer* > *Apache Solr PMC Member* > > e-mail: a.benede...@sease.io > > > *Sease* - Information Retrieval Applied > Consulting | Training | Open Source > > Website: Sease.io <http://sease.io/> > LinkedIn <https://linkedin.com/company/sease-ltd> | Twitter > <https://twitter.com/seaseltd> | Youtube > <https://www.youtube.com/channel/UCDx86ZKLYNpI3gzMercM7BQ> | Github > <https://github.com/seaseltd> > > > On Fri, 9 Jun 2023 at 23:53, Uwe Schindler <u...@thetaphi.de> wrote: > >> Hi, >> >> BTW, there was a slight change in APIJARs caused by this API change: >> https://github.com/openjdk/jdk/commit/5fc9b5787dc4d7f00d2c59288bc8d840fdf5b495 >> (this does not affect our code, but it was done 3 weeks ago). I hope >> something like this won't happen. I updated the PR, no code changes needed >> as those methods were not used by Lucene. >> >> I'd like to update the APIJARS again shortly before the feature branch is >> created. >> >> Uwe >> Am 09.06.2023 um 23:10 schrieb Uwe Schindler: >> >> Let me merge and backport the java 21 map PR first. It has all new source >> directories and APIJAR files. >> >> For safety I will regenerate the 21 APIJAR with newest jdk build. Fyi, to >> regenerate you need to have an environment variable with jdk21 as >> autoprovisioning doesn't work. >> >> After that we can copy-paste the vector impl to the main/java21 folder >> and add vector classes to it. >> >> Uwe >> >> >> Am 9. Juni 2023 22:30:09 MESZ schrieb Chris Hegarty >> <christopher.hega...@elastic.co.INVALID> >> <christopher.hega...@elastic.co.INVALID>: >> >>> Hi, >>> >>> On 9 Jun 2023, at 17:19, Uwe Schindler <u...@thetaphi.de> >>> <u...@thetaphi.de> wrote: >>> >>> Hi, >>> >>> if possible I would like to get the Java 21 changes (MemorySegments and >>> Vector) into the release. I'd like to ask Chris who has better knowledge >>> how to proceed. If he suggests to wait maybe a week or 2, I'd suggest to >>> wait that time. >>> >>> Chris Hegarthy: Do you know if the API of JDK 21 is finalized or not. >>> From my understanding the final phases have started, so API changes are >>> unlikely. If there are bug fixes they won't affect public APIs or the >>> incubator module, right? >>> >>> Your understanding is correct. I do not expect any API changes at this >>> point. >>> >>> The MMapDir changes are already tested all the time, vector API needs >>> the forward port to 21. >>> >>> We are also doing some early testing with JDK 21 EA, and it would be >>> great to get the 21-version of Panama VectorUtils in. I can help get this >>> done. >>> >>> Uwe, what has been done so far? If nothing, as that is still the case >>> tomorrow, I can start on it. >>> >>> -Chris. >>> >>> Uwe >>> Am 09.06.2023 um 18:07 schrieb Adrien Grand: >>> >>> Hello all, >>> >>> There is some good stuff that is scheduled for 9.7 already, I found the >>> following changes in the changelog that look especially interesting: >>> - Concurrent query rewrites for vector queries. >>> - Speedups to vector indexing/search via integration of the Panama >>> vector API. >>> - Reduced overhead of soft deletes. >>> - Support for update by query. >>> >>> I propose we start the process for a 9.7 release, and I volunteer to be >>> the release manager. I suggest the following schedule: >>> - Feature freeze on June 16th, one week from now. This is when the 9.7 >>> branch will be cut. >>> - Open a vote on June 21st, which we'll possibly delay if blockers get >>> identified. >>> >>> -- >>> Adrien >>> >>> -- >>> Uwe Schindler >>> Achterdiek 19, D-28357 Bremenhttps://www.thetaphi.de >>> eMail: u...@thetaphi.de >>> >>> >>> -- >> Uwe Schindler >> Achterdiek 19, 28357 Bremen >> https://www.thetaphi.de >> >> -- >> Uwe Schindler >> Achterdiek 19, D-28357 Bremenhttps://www.thetaphi.de >> eMail: u...@thetaphi.de >> >> -- Adrien
