Thanks Chris for checking.

I had been too optimistic for #12180, I'll push it to 9.10.

Fingers crossed that #12699 fixes the performance drop.


Le lun. 27 nov. 2023, 07:17, Chris Hegarty <christopher.hega...@elastic.co>
a écrit :

> Hi Adrien,
>
> Comments inline.
>
> On 21 Nov 2023, at 12:31, Adrien Grand <jpou...@gmail.com> wrote:
>
> +1 9.9 has plenty of great changes indeed! Thanks for volunteering as a
> RM, Chris.
>
> It would be good to try and fix the PKLookup regression that was
> introduced since 9.8:
> http://people.apache.org/~mikemccand/lucenebench/PKLookup.html. Is it
> just about getting #12699 <https://github.com/apache/lucene/pull/12699>
> merged?
>
>
> I see that this is not yet merged. It looks like it is waiting final
> review.
>
>
> Separately, I have a PR that does a small change to the file format of
> postings and skip lists. It's certainly not a blocker for 9.9, but it would
> be convenient to get it into 9.9 since we already changed file formats for
> the switch from PFOR to FOR. Does someone have time to take a look? #12810
> <https://github.com/apache/lucene/pull/12810>
>
>
> I see that this has been merged, and later reverted because of some test
> instability. The new issue tracking this work is #12810
> <https://github.com/apache/lucene/pull/12810> [1]. Are we still expecting
> this to be resolved in 9.9.0 ?
>
> -Chris.
>
> [1] https://github.com/apache/lucene/pull/12810
>
>
> On Tue, Nov 21, 2023 at 11:16 AM Michael McCandless <
> luc...@mikemccandless.com> wrote:
>
>> +1
>>
>> Thank you for volunteering as RC Chris!
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Tue, Nov 21, 2023 at 4:52 AM Chris Hegarty
>> <christopher.hega...@elastic.co.invalid> wrote:
>>
>>> Hi,
>>>
>>> It's been a while since the 9.8.0 release and we’ve accumulated quite a
>>> few changes. I’d like to propose that we release 9.9.0.
>>>
>>> If there's no objections, I volunteer to be the release manager and will
>>> cut the feature branch a week from now, 12:00 28th Nov UTC.
>>>
>>> -Chris.
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>>
>>>
>
> --
> Adrien
>
>
>

Reply via email to