Sorry, PR link: https://github.com/apache/lucene/pull/12865
-Chris On Saturday, December 2, 2023, Uwe Schindler <u...@thetaphi.de> wrote: > Hi Chris, > > I can't find the PR. > > > > I am interested, because I wrote the original ParallelReader tests. > > IMHO the parallel readers are so sensitive to random changes, the test > setup should not use any indexwriter randomization at all. > > ParallelReader is also seldomly used, maybe we should remove support at > some point. I don't know anybody using it, because it is very complicated > to maintain consistent indexes. It only works with stable merge policies. > > Uwe > > > Am 2. Dezember 2023 09:34:46 MEZ schrieb Chris Hegarty > <christopher.hega...@elastic.co.INVALID>: > >> Hi, >> >> I noticed this failure locally, and opened a PR for it yesterday. It is a >> test issues, and indeed related to the recent merge policy test >> randomization change. >> >> -Chris >> >> On Saturday, December 2, 2023, Patrick Zhai <zhai7...@gmail.com> wrote: >> >>> Seems it's because this MockRandomMergePolicy change >>> <https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java#L242> >>> recently >>> makes ParallelLeafReader unhappy - it's reading two parallel segments from >>> 2 dir and this MP makes one of the segments' documents order reversed. >>> >>> But should be just test util issue and not affecting release. >>> >>> Adrien do you want to take a look? I'm not sure what's the best way to >>> fix it, adding an index sort for that test seems a bit overkill? >>> >>> Patrick >>> >>> On Fri, Dec 1, 2023 at 2:06 PM Michael McCandless < >>> luc...@mikemccandless.com> wrote: >>> >>>> Hmm this reproduces for me, and looks new/unique. Could it be related >>>> to recent 9.9.0 changes / release blocker? >>>> >>>> Mike >>>> >>>> On Fri, Dec 1, 2023 at 3:33 PM Policeman Jenkins Server < >>>> jenk...@thetaphi.de> wrote: >>>> >>>>> Build: https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/14204/ >>>>> Java: 64bit/hotspot/jdk-11.0.21 -XX:+UseCompressedOops >>>>> -XX:+UseParallelGC >>>>> >>>>> 1 tests failed. >>>>> FAILED: org.apache.lucene.index.TestParallelLeafReader.testQueries >>>>> >>>>> Error Message: >>>>> org.junit.ComparisonFailure: expected:<v[2]> but was:<v[1]> >>>>> >>>>> Stack Trace: >>>>> org.junit.ComparisonFailure: expected:<v[2]> but was:<v[1]> >>>>> at __randomizedtesting.SeedInfo.s >>>>> eed([6CA57EA3FB50CA0D:302BB278E1397FA3]:0) >>>>> at org.junit.Assert.assertEquals(Assert.java:117) >>>>> at org.junit.Assert.assertEquals(Assert.java:146) >>>>> at org.apache.lucene.index.TestPa >>>>> rallelLeafReader.queryTest(TestParallelLeafReader.java:263) >>>>> at org.apache.lucene.index.TestPa >>>>> rallelLeafReader.testQueries(TestParallelLeafReader.java:48) >>>>> at java.base/jdk.internal.reflect >>>>> .NativeMethodAccessorImpl.invoke0(Native Method) >>>>> at java.base/jdk.internal.reflect >>>>> .NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>>> at java.base/jdk.internal.reflect >>>>> .DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso >>>>> rImpl.java:43) >>>>> at java.base/java.lang.reflect.Method.invoke(Method.java:566) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.RandomizedRunner.invoke(RandomizedRunner.java:1758) >>>>> at com.carrotsearch.randomizedtesting.RandomizedRunner$8. >>>>> evaluate(RandomizedRunner.java:946) >>>>> at com.carrotsearch.randomizedtesting.RandomizedRunner$9. >>>>> evaluate(RandomizedRunner.java:982) >>>>> at com.carrotsearch.randomizedtesting.RandomizedRunner$10. >>>>> evaluate(RandomizedRunner.java:996) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardown >>>>> Chained.java:48) >>>>> at org.apache.lucene.tests.util.A >>>>> bstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfter >>>>> MaxFailures.java:60) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) >>>>> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >>>>> at com.carrotsearch.randomizedtesting.rules.StatementAdapter. >>>>> evaluate(StatementAdapter.java:36) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843) >>>>> at com.carrotsearch.randomizedtesting.ThreadLeakControl$3. >>>>> evaluate(ThreadLeakControl.java:490) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955) >>>>> at com.carrotsearch.randomizedtesting.RandomizedRunner$5. >>>>> evaluate(RandomizedRunner.java:840) >>>>> at com.carrotsearch.randomizedtesting.RandomizedRunner$6. >>>>> evaluate(RandomizedRunner.java:891) >>>>> at com.carrotsearch.randomizedtesting.RandomizedRunner$7. >>>>> evaluate(RandomizedRunner.java:902) >>>>> at org.apache.lucene.tests.util.A >>>>> bstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >>>>> at com.carrotsearch.randomizedtesting.rules.StatementAdapter. >>>>> evaluate(StatementAdapter.java:36) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(No >>>>> ShadowingOrOverridesOnMethodsRule.java:40) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(No >>>>> ShadowingOrOverridesOnMethodsRule.java:40) >>>>> at com.carrotsearch.randomizedtesting.rules.StatementAdapter. >>>>> evaluate(StatementAdapter.java:36) >>>>> at com.carrotsearch.randomizedtesting.rules.StatementAdapter. >>>>> evaluate(StatementAdapter.java:36) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequi >>>>> red.java:53) >>>>> at org.apache.lucene.tests.util.A >>>>> bstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfter >>>>> MaxFailures.java:60) >>>>> at org.apache.lucene.tests.util.T >>>>> estRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47) >>>>> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >>>>> at com.carrotsearch.randomizedtesting.rules.StatementAdapter. >>>>> evaluate(StatementAdapter.java:36) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390) >>>>> at com.carrotsearch.randomizedtes >>>>> ting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLea >>>>> kControl.java:850) >>>>> at java.base/java.lang.Thread.run(Thread.java:829) >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: builds-unsubscr...@lucene.apache.org >>>>> For additional commands, e-mail: builds-h...@lucene.apache.org >>>> >>>> -- > Uwe Schindler > Achterdiek 19, 28357 Bremen > <https://www.google.com/maps/search/Achterdiek+19,+28357+Bremen?entry=gmail&source=g> > https://www.thetaphi.de >
