[ 
https://issues.apache.org/jira/browse/LUCENE-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121372#comment-13121372
 ] 

Mark Miller commented on LUCENE-3488:
-------------------------------------

bq. and continue to be met with push back. 

Arn't you used to pushback on your code / ideas by now?
                
> Factor out SearcherManager from NRTManager
> ------------------------------------------
>
>                 Key: LUCENE-3488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3488
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.5, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3488.patch
>
>
> Currently we have NRTManager and SearcherManager while NRTManager contains a 
> big piece of the code that is already in SearcherManager. Users are kind of 
> forced to use NRTManager if they want to have SearcherManager goodness with 
> NRT. The integration into NRTManager also forces you to maintain two 
> instances even if you know you always want deletes. To me NRTManager tries to 
> do more than necessary and mixes lots of responsibilities ie. handling 
> searchers and handling indexing generations. NRTManager should use a 
> SearcherManager by aggregation rather than duplicate a lot of logic. 
> SearcherManager should have a NRT and Directory based implementation users 
> can simply choose from.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to