[
https://issues.apache.org/jira/browse/LUCENE-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-3488:
---------------------------------------
Attachment: LUCENE-3488.patch
This is great Simon!
I love how you now ask NRTMgr for a w/ deletes and w/o deletes
SearcherManager, and then can just use the SearcherMgr from then on
(optionally waiting for the right gen, on the NRTMgr, if you need to).
Maybe we can somehow take this further... like you open a separate
NRTMgr that doesn't care about deletes (this is super-expert anyway);
then we don't have the "if (mustApplyDeletes)" throughout (but we can
do this under a new issue).
I made some small cleanups (removed some "TODO Auto-generated method
stub"s); renamed NRTSearchManager -> NRTSearcherManager (the inner
class in SearcherManager; added default ctor setting
alwaysApplyDeletes=true in NRTManager; put synchronized back in
SearcherManager.swapSearcher (ok?)).
> Factor out SearcherManager from NRTManager
> ------------------------------------------
>
> Key: LUCENE-3488
> URL: https://issues.apache.org/jira/browse/LUCENE-3488
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.5, 4.0
> Reporter: Simon Willnauer
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3488.patch, LUCENE-3488.patch
>
>
> Currently we have NRTManager and SearcherManager while NRTManager contains a
> big piece of the code that is already in SearcherManager. Users are kind of
> forced to use NRTManager if they want to have SearcherManager goodness with
> NRT. The integration into NRTManager also forces you to maintain two
> instances even if you know you always want deletes. To me NRTManager tries to
> do more than necessary and mixes lots of responsibilities ie. handling
> searchers and handling indexing generations. NRTManager should use a
> SearcherManager by aggregation rather than duplicate a lot of logic.
> SearcherManager should have a NRT and Directory based implementation users
> can simply choose from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
