[
https://issues.apache.org/jira/browse/LUCENE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121852#comment-13121852
]
Shai Erera commented on LUCENE-3262:
------------------------------------
bq. ItemSource.resetInputs
I don't have that warning turned on in Eclipse. I disabled it for exactly this
reason :).
bq. ItemSource rename
The new name is ok, and the properties better fit it. BTW, if you wanted to
have the .algs out there to not silently fail, you could add some code to
setConfig that checks for these outdated properties, and throw a proper
exception. But I'm ok with the solution you chose.
bq. PFD.readers.incRef()
The javadocs are good. I'd also add "<b>NOTE:</b> if you no longer need that
IndexReader/TaxoReader, you should decRef()/close() after calling this method".
Otherwise, the IR/TR will just stay open ...
> Facet benchmarking
> ------------------
>
> Key: LUCENE-3262
> URL: https://issues.apache.org/jira/browse/LUCENE-3262
> Project: Lucene - Java
> Issue Type: New Feature
> Components: modules/benchmark, modules/facet
> Reporter: Shai Erera
> Assignee: Doron Cohen
> Attachments: CorpusGenerator.java, LUCENE-3262.patch,
> TestPerformanceHack.java
>
>
> A spin off from LUCENE-3079. We should define few benchmarks for faceting
> scenarios, so we can evaluate the new faceting module as well as any
> improvement we'd like to consider in the future (such as cutting over to
> docvalues, implement FST-based caches etc.).
> Toke attached a preliminary test case to LUCENE-3079, so I'll attach it here
> as a starting point.
> We've also done some preliminary job for extending Benchmark for faceting, so
> I'll attach it here as well.
> We should perhaps create a Wiki page where we clearly describe the benchmark
> scenarios, then include results of 'default settings' and 'optimized
> settings', or something like that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
