[ 
https://issues.apache.org/jira/browse/LUCENE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122134#comment-13122134
 ] 

Shai Erera commented on LUCENE-3262:
------------------------------------

bq. I think this is ready to commit.

+1. Perhaps just add a CHANGES entry?

bq. but that can go in a separate issue

I think it's better if we resolve it in that issue, and maybe rename the issue 
to "Facet benchmarking framework". You can still commit the current progress 
because it is 'whole' - covering the indexing side. I've worked on issues 
before that had several commits, so this will not be the first one.

We should also run some benchmark tests, describing clearly the data sets, but 
this can be done under a separate issue.
                
> Facet benchmarking
> ------------------
>
>                 Key: LUCENE-3262
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3262
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: modules/benchmark, modules/facet
>            Reporter: Shai Erera
>            Assignee: Doron Cohen
>         Attachments: CorpusGenerator.java, LUCENE-3262.patch, 
> LUCENE-3262.patch, TestPerformanceHack.java
>
>
> A spin off from LUCENE-3079. We should define few benchmarks for faceting 
> scenarios, so we can evaluate the new faceting module as well as any 
> improvement we'd like to consider in the future (such as cutting over to 
> docvalues, implement FST-based caches etc.).
> Toke attached a preliminary test case to LUCENE-3079, so I'll attach it here 
> as a starting point.
> We've also done some preliminary job for extending Benchmark for faceting, so 
> I'll attach it here as well.
> We should perhaps create a Wiki page where we clearly describe the benchmark 
> scenarios, then include results of 'default settings' and 'optimized 
> settings', or something like that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to