[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157148#comment-13157148 ]
Uwe Schindler commented on LUCENE-3595: --------------------------------------- I committed a change in trunk branch to do the acceptDocs check after the matchDoc() to be consistent with other implementations. This should also be faster as bit twiddling is only done when a match was found. At revision: 1206155 > Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and > fix the dangerous matchDoc() throws AIOOBE requirement > --------------------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-3595 > URL: https://issues.apache.org/jira/browse/LUCENE-3595 > Project: Lucene - Java > Issue Type: Task > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3595-3x.patch, LUCENE-3595-3x.patch, > LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch > > > Followup from LUCENE-3593: > The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement > on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. > This check should be done by caller as especially on trunk, e.g. > FieldCacheTermsFilter does not seem to always throw this exception correctly > (getOrd() is a method and no array in TermsIndex cache). > Also in 3.x the Filter does not correctly respect deletions when a FieldCache > based on a reopened reader is used. > This issue will refactor this and fix the bugs and moves the docId check up > to the iterator. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org