[ https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163878#comment-13163878 ]
David Smiley commented on SOLR-2920: ------------------------------------ Anybody have any opinion here? I'd love to get this issue to a resolution. > Refactor frequent conditional use of DefaultSolrParams into > SolrParams.combine(p,d) > ----------------------------------------------------------------------------------- > > Key: SOLR-2920 > URL: https://issues.apache.org/jira/browse/SOLR-2920 > Project: Solr > Issue Type: Improvement > Reporter: David Smiley > Priority: Minor > Attachments: SOLR-2920_SolrParams_combine().patch > > > I had a small bug in use of DefaultSolrParams in my code because I didn't > check for non-existent defaults. I noticed through the Solr codebase that is > code pattern is very common: > {code:java} > if( defaults != null ) { > params = new DefaultSolrParams( params, defaults ); > } > {code} > Instead, I refactored this logic into a new SolrParams.combine(p,d) method > and made it so that nobody refers to DefaultSolrParams. I did similarly for > AppendedSolrParams. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org