[
https://issues.apache.org/jira/browse/LUCENE-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-3623:
--------------------------------
Attachment: LUCENE-3623.patch
patch: cleaning up and removing the nocommit.
I see whats going on now, IDV as a side effect when merging changes the
fieldinfo if necessary... this was what I was missing before.
I think this has to do with how merging/type promotion works in IDV, it seems
type promotion is "extendable" by the codec, but I'm not sure it should be: I
think it should be part of the abstract API and well-defined. But thats
refactoring/discussion for another issue, for now I'd like to commit this to
fix the dataloss/bug.
I'll commit tomorrow if there are no objections.
> SegmentReader.getFieldNames ignores FieldOption.DOC_VALUES
> ----------------------------------------------------------
>
> Key: LUCENE-3623
> URL: https://issues.apache.org/jira/browse/LUCENE-3623
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3623.patch, LUCENE-3623.patch,
> LUCENE-3623_test.patch
>
>
> we use this getFieldNames api in segmentmerger if we merge something that
> isn't a SegmentReader (e.g. FilterIndexReader)
> it looks to me that if you use a FilterIndexReader, call
> addIndexes(Reader...) the docvalues will be simply dropped.
> I dont think its enough to just note that the field has docvalues either
> right? We need to also set the type
> correctly in the merged field infos? This would imply that instead of
> FieldOption.DOCVALUES, we need to have a
> FieldOption for each ValueType so that we correctly update the type.
> But looking at FI.update/setDocValues, it doesn't look like we 'type-promote'
> here anyway?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
