[ 
https://issues.apache.org/jira/browse/LUCENE-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164347#comment-13164347
 ] 

Simon Willnauer commented on LUCENE-3623:
-----------------------------------------

MultiSource should just override asSortedSource() and throw an 
unsupportedOperationException.
                
> SegmentReader.getFieldNames ignores FieldOption.DOC_VALUES
> ----------------------------------------------------------
>
>                 Key: LUCENE-3623
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3623
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3623.patch, LUCENE-3623.patch, LUCENE-3623.patch, 
> LUCENE-3623_test.patch
>
>
> we use this getFieldNames api in segmentmerger if we merge something that 
> isn't a SegmentReader (e.g. FilterIndexReader)
> it looks to me that if you use a FilterIndexReader, call 
> addIndexes(Reader...) the docvalues will be simply dropped.
> I dont think its enough to just note that the field has docvalues either 
> right? We need to also set the type 
> correctly in the merged field infos? This would imply that instead of 
> FieldOption.DOCVALUES, we need to have a 
> FieldOption for each ValueType so that we correctly update the type.
> But looking at FI.update/setDocValues, it doesn't look like we 'type-promote' 
> here anyway?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to