[ 
https://issues.apache.org/jira/browse/LUCENE-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-3681:
---------------------------------------

    Attachment: LUCENE-3681.patch

Simple patch...
                
> FST.BYTE2 should save as fixed 2 byte not as vInt
> -------------------------------------------------
>
>                 Key: LUCENE-3681
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3681
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3681.patch
>
>
> We currently write BYTE1 as a single byte, but BYTE2/4 as vInt, but I think 
> that's confusing.  Also, for the FST for the new Kuromoji analyzer 
> (LUCENE-3305), writing as 2 bytes instead shrank the FST and ran faster, 
> presumably because more values were >= 16384 than were < 128.
> Separately the whole INPUT_TYPE is very confusing... really all it's doing is 
> "declaring" the allowed range of the characters of the input alphabet, and 
> then the only thing that uses that is the write/readLabel methods (well and 
> some confusing sugar methods in Builder!).  Not sure how to fix that yet...
> It's a simple change but it changes the FST binary format so any users w/ 
> FSTs out there will have to rebuild (FST is marked experimental...).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to