[
https://issues.apache.org/jira/browse/LUCENE-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186629#comment-13186629
]
Michael McCandless commented on LUCENE-3602:
--------------------------------------------
Looking great!
* Can't TermsCollector be package private? Like it's only used
privately in JoinUtil.createJoinQuery?
* Can JoinUtil.createJoinQuery return Query not MultiTermQuery...?
Just gives us freedom in the future to impl a different Query if
we want/need to...
* Typo: collecter -> collector
* Can TermsQuery be package private? Also, we can save a pass over
the sorted terms by having TermsQuery hold the int[] ord array and
then just do the lookup (against BytesRefHash) as it
goes... really TermsQuery could just take the BytesRefHash. Then
we wouldn't have to materialize a new BytesRef for each matched
term... just reuse a single scratch BytesRef inside TermsQuery.
* In the TermsQuery.accept... should that {{return AcceptStatus.YES}}
in the {{if (cmp == 0)}} be a YES_AND_SEEK
(after setting the next term as the seekTerm)?
* Hmm we sort by unicode order in TermsCollector.getCollectedTerms,
but then by the term dict's comparator in TermsQuery; maybe just
use the UTF8AsUnicode comparator in TermsQuery too? And note in
jdocs that this is required?
> Add join query to Lucene
> ------------------------
>
> Key: LUCENE-3602
> URL: https://issues.apache.org/jira/browse/LUCENE-3602
> Project: Lucene - Java
> Issue Type: New Feature
> Components: modules/join
> Reporter: Martijn van Groningen
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3602.patch, LUCENE-3602.patch, LUCENE-3602.patch,
> LUCENE-3602.patch, LUCENE-3602.patch, LUCENE-3602.patch
>
>
> Solr has (psuedo) join query for a while now. I think this should also be
> available in Lucene.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
