[ https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206461#comment-13206461 ]
Robert Muir commented on LUCENE-3774: ------------------------------------- {quote} Having a few top-level exclusion rules in the fileset (build folders, example folders) is not that bad to me. {quote} Keep in mind also, that when I see things like ".." from lucene/, I know this cannot totally work, because lucene/ must be buildable/packagable by itself (its broken in trunk that this doesn't work today, mostly because hudson does not test this is the case: LUCENE-2974). > check-legal isn't doing its job > ------------------------------- > > Key: LUCENE-3774 > URL: https://issues.apache.org/jira/browse/LUCENE-3774 > Project: Lucene - Java > Issue Type: Improvement > Components: general/build > Affects Versions: 3.6, 4.0 > Reporter: Steven Rowe > Assignee: Steven Rowe > Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch > > > In trunk, the {{check-legal-lucene}} ant target is not checking any > {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories > are not being checked; and {{check-legal-solr}} can't be checking > {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files > in there that don't have a license. > These targets are set up to take in a full list of {{lib/}} directories in > which to check, but modules move around, and these lists are not being kept > up-to-date. > Instead, {{check-legal-\*}} should run for each module, if the module has a > {{lib/}} directory, and it should be specialized for modules that have more > than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard > place ({{lucene/core/}}). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org