[ https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206488#comment-13206488 ]
Steven Rowe edited comment on LUCENE-3774 at 2/12/12 7:08 PM: -------------------------------------------------------------- bq. I'll re-generate the patch. bq. git patch with --no-prefix? Thanks! This patch worked for me (using {{patch -p0 < LUCENE\-3774.patch}}). bq. I've looked at this: http://stackoverflow.com/questions/3418277/how-to-apply-git-diff-patch I tried another suggestion from this web page, using your original patch: {{patch -p1 < LUCENE\-3774.patch}}. This also worked, so there was no reason to re-generate after all - sorry about that. bq. Currently we require ANT 1.7 (and hudson/myself always uses ANT 1.7), so: Do we need to upgrade? I use Ant 1.7.1, and Dawid's patch worked for me, so I don't think we need to upgrade? After applying the patch, when I run {{ant validate}} at the top level, I get the following: {noformat} validate: [license-check] MISSING NOTICE for the license file: [license-check] C:\cygwin\home\s\svn\lucene\dev\trunk\solr\contrib\langid\lib\jsonic-LICENSE-ASL.txt [license-check] Expected location below: [license-check] C:\cygwin\home\s\svn\lucene\dev\trunk\solr\contrib\langid\lib\jsonic-NOTICE.txt [license-check] Scanned 82 JAR file(s) for licenses (in 4.71s.), 0 error(s). {noformat} This tooks significantly longer for me than for you, Dawid: 4.71s vs. 0.12s (maybe disk caching effects? I have an SSD...). Even so, it's fast enough not to cause trouble. was (Author: steve_rowe): bq. I'll re-generate the patch. bq. git patch with --no-prefix? Thanks! This patch worked for me (using {{patch -p0 < LUCENE\-3774.patch}}). bq. I've looked at this: http://stackoverflow.com/questions/3418277/how-to-apply-git-diff-patch I tried another suggestion from this web page, using your original patch: {{patch -p1 < LUCENE\-3774.patch}}). This also worked, so there was no reason to re-generate after all - sorry about that. bq. Currently we require ANT 1.7 (and hudson/myself always uses ANT 1.7), so: Do we need to upgrade? I use Ant 1.7.1, and Dawid's patch worked for me, so I don't think we need to upgrade? After applying the patch, when I run {{ant validate}} at the top level, I get the following: {noformat} validate: [license-check] MISSING NOTICE for the license file: [license-check] C:\cygwin\home\s\svn\lucene\dev\trunk\solr\contrib\langid\lib\jsonic-LICENSE-ASL.txt [license-check] Expected location below: [license-check] C:\cygwin\home\s\svn\lucene\dev\trunk\solr\contrib\langid\lib\jsonic-NOTICE.txt [license-check] Scanned 82 JAR file(s) for licenses (in 4.71s.), 0 error(s). {noformat} This tooks significantly longer for me than for you, Dawid: 4.71s vs. 0.12s (maybe disk caching effects? I have an SSD...). Even so, it's fast enough not to cause trouble. > check-legal isn't doing its job > ------------------------------- > > Key: LUCENE-3774 > URL: https://issues.apache.org/jira/browse/LUCENE-3774 > Project: Lucene - Java > Issue Type: Improvement > Components: general/build > Affects Versions: 3.6, 4.0 > Reporter: Steven Rowe > Assignee: Steven Rowe > Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch, > LUCENE-3774.patch > > > In trunk, the {{check-legal-lucene}} ant target is not checking any > {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories > are not being checked; and {{check-legal-solr}} can't be checking > {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files > in there that don't have a license. > These targets are set up to take in a full list of {{lib/}} directories in > which to check, but modules move around, and these lists are not being kept > up-to-date. > Instead, {{check-legal-\*}} should run for each module, if the module has a > {{lib/}} directory, and it should be specialized for modules that have more > than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard > place ({{lucene/core/}}). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org