[ 
https://issues.apache.org/jira/browse/LUCENE-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224774#comment-13224774
 ] 

Martijn van Groningen commented on LUCENE-3778:
-----------------------------------------------

{quote}
So, yeah, I think default to Sort.RELEVANCE is good? Maybe we have 1
search method doing that and another taking the GroupSort?

I think it's strange to have a default for the top N groups (10)? I
think app should have to specify that as an arg to search...
{quote}
Makes sense.

bq. I think GroupingSearch (current name) is OK?
In the join module we have the JoinUtil. Maybe rename it to GroupUtil? Just to 
be consistent? Or rename JoinUtil to JoinSearch?
                
> Create a grouping convenience class
> -----------------------------------
>
>                 Key: LUCENE-3778
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3778
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/grouping
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-3778.patch, LUCENE-3778.patch
>
>
> Currently the grouping module has many collector classes with a lot of 
> different options per class. I think it would be a good idea to have a 
> GroupUtil (Or another name?) convenience class. I think this could be a 
> builder, because of the many options 
> (sort,sortWithinGroup,groupOffset,groupCount and more) and implementations 
> (term/dv/function) grouping has.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to