[ https://issues.apache.org/jira/browse/LUCENE-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227041#comment-13227041 ]
Michael McCandless commented on LUCENE-3778: -------------------------------------------- bq. I think that the package.html should also be updated? It should use the GroupSearch instead of all the different collectors. +1, as long as GroupSearch covers all cases package.html now describes I guess? > Create a grouping convenience class > ----------------------------------- > > Key: LUCENE-3778 > URL: https://issues.apache.org/jira/browse/LUCENE-3778 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/grouping > Reporter: Martijn van Groningen > Attachments: LUCENE-3778.patch, LUCENE-3778.patch > > > Currently the grouping module has many collector classes with a lot of > different options per class. I think it would be a good idea to have a > GroupUtil (Or another name?) convenience class. I think this could be a > builder, because of the many options > (sort,sortWithinGroup,groupOffset,groupCount and more) and implementations > (term/dv/function) grouping has. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org