[ https://issues.apache.org/jira/browse/LUCENE-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232712#comment-13232712 ]
Uwe Schindler commented on LUCENE-3883: --------------------------------------- Hi, very funny lowercase filter! :-) One thing: It does not actually ArrayIndexOutOfBoundsEx in the filter because of the way how CharTermAttributeImpl is implemented internally, but theoretically there is a length check missing. The nUpper/tUpper stuff can get out of bounds if the length of term in 0 or 1 (which are valid length). But thats only a minor complaint about the code. Otherwise looks great. Just appearing from no irish support at all! really needed! :-) Uwe > Analysis for Irish > ------------------ > > Key: LUCENE-3883 > URL: https://issues.apache.org/jira/browse/LUCENE-3883 > Project: Lucene - Java > Issue Type: New Feature > Components: modules/analysis > Reporter: Jim Regan > Priority: Trivial > Labels: analysis, newbie > Attachments: LUCENE-3883.patch > > > Adds analysis for Irish. > The stemmer is generated from a snowball stemmer. I've sent it to Martin > Porter, who says it will be added during the week. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org