[ https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252172#comment-13252172 ]
Robert Muir commented on LUCENE-2510: ------------------------------------- Hmm looking at this ResourceLoader, what is the purpose of the newInstance method? It seems to be unrelated to the 'resource loading', i think it should be something else? Separately, do we have any vague idea of a plan of how WordListLoader can implement this interface? I don't think we have to do that immediately to proceed, but long term I think it would make sense, since currently we have some duplicate code between lucene and solr here: * take a look at wordlistloader * take a look at the protected methods in BaseTokenStreamFactory. > migrate solr analysis factories to analyzers module > --------------------------------------------------- > > Key: LUCENE-2510 > URL: https://issues.apache.org/jira/browse/LUCENE-2510 > Project: Lucene - Java > Issue Type: Task > Components: modules/analysis > Affects Versions: 4.0 > Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2510.patch > > > In LUCENE-2413 all TokenStreams were consolidated into the analyzers module. > This is a good step, but I think the next step is to put the Solr factories > into the analyzers module, too. > This would make analyzers artifacts plugins to both lucene and solr, with > benefits such as: > * users could use the old analyzers module with solr, too. This is a good > step to use real library versions instead of Version for backwards compat. > * analyzers modules such as smartcn and icu, that aren't currently available > to solr users due to large file sizes or dependencies, would be simple > optional plugins to solr and easily available to users that want them. > Rough sketch in this thread: > http://www.lucidimagination.com/search/document/3465a0e55ba94d58/solr_and_analyzers_module > Practically, I havent looked much and don't really have a plan for how this > will work yet, so ideas are very welcome. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org