[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252179#comment-13252179
]
Chris Male commented on LUCENE-2510:
------------------------------------
bq. what is the purpose of the newInstance method?
If you take a look at
{{org.apache.solr.analysis.DelimitedPayloadTokenFilterFactory}} you'll see an
example of how it's used.
Looking at the implementation in SolrResourceLoader, it seems to facilitate two
things:
- The use of simplified {{solr.*}} package names
- In {{FSTSynonymFilterFactory}} for example, newInstance is used to load other
components. Consequently SolrResourceLoader adds the instantiated classes to
its tracking of SolrCoreAware, ResourceLoaderAware, etc.
With all that said, its only used in 3 Factories (but a lot of other Solr
code). Perhaps we can break it out somehow.
bq. Separately, do we have any vague idea of a plan of how WordListLoader can
implement this interface?
I don't at this stage, but you're right, there is duplication. Off the top of
my head I think we'd want to move everything over to using ResourceLoader, but
somehow incorporate the WordlistLoader logic somewhere.
> migrate solr analysis factories to analyzers module
> ---------------------------------------------------
>
> Key: LUCENE-2510
> URL: https://issues.apache.org/jira/browse/LUCENE-2510
> Project: Lucene - Java
> Issue Type: Task
> Components: modules/analysis
> Affects Versions: 4.0
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-2510.patch
>
>
> In LUCENE-2413 all TokenStreams were consolidated into the analyzers module.
> This is a good step, but I think the next step is to put the Solr factories
> into the analyzers module, too.
> This would make analyzers artifacts plugins to both lucene and solr, with
> benefits such as:
> * users could use the old analyzers module with solr, too. This is a good
> step to use real library versions instead of Version for backwards compat.
> * analyzers modules such as smartcn and icu, that aren't currently available
> to solr users due to large file sizes or dependencies, would be simple
> optional plugins to solr and easily available to users that want them.
> Rough sketch in this thread:
> http://www.lucidimagination.com/search/document/3465a0e55ba94d58/solr_and_analyzers_module
> Practically, I havent looked much and don't really have a plan for how this
> will work yet, so ideas are very welcome.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
