[ 
https://issues.apache.org/jira/browse/SOLR-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397510#comment-13397510
 ] 

Mark Miller commented on SOLR-3488:
-----------------------------------

bq. It seems that in the latest patch even in case of failure the job is 
removed from queue.

Right - I was putting it back on the queue, but once I added deletes, I removed 
that because I was worried about reorderings. I figure we may need a different 
strategy in general. I'll expand on that in a new comment.


bq. report error to user and do not try to create the collection

Yeah, that is one option - then we have to remove the collection on the other 
nodes though. For instance, what happens if one of the create cores calls fails 
due to an intermittent connection error. Do we fail then? We would need to 
clean up first. Then what if one of those nodes fails before we could remove 
it. And then comes back with that core later. I agree that simple might be the 
best bet to start, but in failure scenarios it gets a little muddy quickly. 
Which may be fine to start as you suggest.

bq. I have one question about the patch specifically in the 
OverseerCollectionProcessor where you create the collection: why do you need 
the collection param? 

Mostly just simplicity to start - getting the nodes based on a template 
collection was easy. Tommaso did some work on extracting a strategy class, but 
I have not yet integrated it. Certainly we need more options at a minimum, or 
perhaps just a different strategy. Simplest might be a way to go, but it also 
might be a back compat problem if we choose to do something else. I'll try and 
elaborate in a new comment a bit later today.

bq. and improve things on SVN from now

Okay, that sounds fine to me. I'll try and polish the patch a smidgen and 
commit it as a start soon.
                
> Create a Collections API for SolrCloud
> --------------------------------------
>
>                 Key: SOLR-3488
>                 URL: https://issues.apache.org/jira/browse/SOLR-3488
>             Project: Solr
>          Issue Type: New Feature
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: SOLR-3488.patch, SOLR-3488.patch, SOLR-3488.patch, 
> SOLR-3488_2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to