[
https://issues.apache.org/jira/browse/LUCENE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406278#comment-13406278
]
Chris Male commented on LUCENE-4188:
------------------------------------
I think it is bizarre to first parse the String to a Shape, pass the Shape into
the Strategy, and then the Strategy to ask for the String again. I think we
should let the user decide what they want to store and how it should be stored.
Even if we do decide to use SpatialContext.toString as the default behavior,
it doesn't belong inside the Strategys. Solr can create a separate Field
instance for the stored value and so can other users of the module.
> Storing Shapes shouldn't be Strategy dependent
> ----------------------------------------------
>
> Key: LUCENE-4188
> URL: https://issues.apache.org/jira/browse/LUCENE-4188
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
>
> The logic for storing Shape representations seems to be different for each
> Strategy. The PrefixTreeStrategy impls store the Shape in WKT, which is nice
> if you're using WKT but not much help if you're not. BBoxStrategy doesn't
> actually store the Shape itself, but a representation of the bounding box.
> TwoDoubles seems to follow the PrefixTreeStrategy approach, which is
> surprising since it only indexes Points and they could be stored without
> using WKT.
> I think we need to consider what storing a Shape means. If we want to store
> the Shape itself, then that logic should be standardised and done outside of
> the Strategys since it is not really related to them. If we want to store
> the terms being used by the Strategys to make Shapes queryable, then we need
> to change the logic in the Strategys to actually do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
