[
https://issues.apache.org/jira/browse/LUCENE-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420123#comment-13420123
]
Shai Erera commented on LUCENE-4234:
------------------------------------
Good catch !
I have few comments about the patch:
# Can you merge them into one file?
# Can we use FixedBitSet? It's an improvement over OpenBitSet, without needing
to use fastXYZ
# I think that we can initialize the scores array to maxDoc, and drop the
resizing in collect -- collect is a hot method, we should do minimal work
there. If someone want to keep scores for maxDoc documents, we should
initialize the array up front.
> Exception when FacetsCollector is used with ScoreFacetRequest
> -------------------------------------------------------------
>
> Key: LUCENE-4234
> URL: https://issues.apache.org/jira/browse/LUCENE-4234
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 3.6, 4.0-ALPHA
> Reporter: Gilad Barkai
> Assignee: Shai Erera
> Fix For: 4.0, 5.0, 3.6.2
>
> Attachments: LUCENE-4234-fix.patch, LUCENE-4234-test.patch
>
>
> Aggregating facets with Lucene's Score using FacetsCollector results in an
> Exception (assertion when enabled).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
