[ 
https://issues.apache.org/jira/browse/LUCENE-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420125#comment-13420125
 ] 

Gilad Barkai commented on LUCENE-4234:
--------------------------------------

Hi Shai, thank you for reviewing.

1. Merged
2. Using FBS is possible, though it's a larger change than the fix, perhaps 
handle this in a seperate issue?
3. IMHO that's a waste for a large index. While allocating a large array is 
faster, it takes a lot of memory - probably for no reason. Each query will take 
longer, but concurrent queries will not hurt the GC that much. If the index is 
large concurrent queries might hit the GC hard, perhaps even OOM ? I must admit 
I never measured the reallocation penalty.
                
> Exception when FacetsCollector is used with ScoreFacetRequest
> -------------------------------------------------------------
>
>                 Key: LUCENE-4234
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4234
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>    Affects Versions: 3.6, 4.0-ALPHA
>            Reporter: Gilad Barkai
>            Assignee: Shai Erera
>             Fix For: 4.0, 5.0, 3.6.2
>
>         Attachments: LUCENE-4234.patch
>
>
> Aggregating facets with Lucene's Score using FacetsCollector results in an 
> Exception (assertion when enabled).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to