[
https://issues.apache.org/jira/browse/LUCENE-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449583#comment-13449583
]
Uwe Schindler edited comment on LUCENE-4364 at 9/6/12 10:51 PM:
----------------------------------------------------------------
I have nothing against that, but it is *not* completely untested, look at the
code :-) When you clone a slice, the offset of the original must be applied by
the code when calling the private slice method - and that is done now. This was
necessary to unify the clone and slice method to one common code. cloning is
now only slice with 0..length.
But I agree we should not support this until we remove the IndexInputSlicer
class at all and make every IndexInput sliceable (in a later issue). There is
no chance that user code can call this method, as it is private to
ByteBufferIndexInput.
was (Author: thetaphi):
I have nothing against that, but it is *not* completely untested, look at
the code :-) When you clone a slice, the offset of the original must be applied
by the code when calling the private slice method - and that is done now. This
was necessary to unify the clone and slice method to one common code.
But I agree we should not support this until we remove the IndexInputSlicer
class at all and make every IndexInput sliceable (in a later issue). There is
no chance that user code can call this method, as it is private to
ByteBufferIndexInput.
> MMapDirectory makes too many maps for CFS
> -----------------------------------------
>
> Key: LUCENE-4364
> URL: https://issues.apache.org/jira/browse/LUCENE-4364
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-4364.patch, LUCENE-4364.patch, LUCENE-4364.patch,
> LUCENE-4364.patch, LUCENE-4364.patch
>
>
> While looking at LUCENE-4123, i thought about this:
> I don't like how mmap creates a separate mapping for each CFS slice, to me
> this is way too many mmapings.
> Instead I think its slicer should map the .CFS file, and then when asked for
> an offset+length slice of that, it should be using .duplicate()d buffers of
> that single master mapping.
> then when you close the .CFS it closes that one mapping.
> this is probably too scary for 4.0, we should take our time, but I think we
> should do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
