[
https://issues.apache.org/jira/browse/LUCENE-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-4364:
--------------------------------
Attachment: LUCENE-4364.patch
updated patch: I removed the assert 0L (its a contract of the method slice)
from the openSlice method, and added back the IAE if you try to slice from a
clone.
as far as the openFullSlice, the assert is correct (for 4.x maybe), but in
trunk we don't even need this method: its a back compat shim for reading older
3.x formatted .cfs files, which trunk no longer supports. this is just dead
code: I removed it: we should deprecate it from 4.x
> MMapDirectory makes too many maps for CFS
> -----------------------------------------
>
> Key: LUCENE-4364
> URL: https://issues.apache.org/jira/browse/LUCENE-4364
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-4364.patch, LUCENE-4364.patch, LUCENE-4364.patch,
> LUCENE-4364.patch, LUCENE-4364.patch, LUCENE-4364.patch
>
>
> While looking at LUCENE-4123, i thought about this:
> I don't like how mmap creates a separate mapping for each CFS slice, to me
> this is way too many mmapings.
> Instead I think its slicer should map the .CFS file, and then when asked for
> an offset+length slice of that, it should be using .duplicate()d buffers of
> that single master mapping.
> then when you close the .CFS it closes that one mapping.
> this is probably too scary for 4.0, we should take our time, but I think we
> should do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
