[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362_trunk.patch
LUCENE-4362_4x.patch
Right. Finally got back to this, traveling really hurts. Anyway...
I'm about ready to check this all in, running tests now.
regenerated all the .jj and .jflex files, those get checked in too, right?
Speak now or....
All that's left as far as .java files is concerned is the pesky
// numRead < 0
in things like HtmlStripCharFilterFactory.java that jflex generates.
And can we please put in the check real soon now? Two more files have been
checked in over the last week with tabs....
Note, I've only looked at java files and their precursors. I've ignored all
.xml, .vm, .js, .<anything except java>
Latest patches attached.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch,
> LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch,
> LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author
> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author
> tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
