[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362_4x.patch
LUCENE-4362_trunk.patch
I don't think so. Thanks to your help, I did nuke my jflex, re-checkout, mvn
install and re-run jflex.
My generated files have this notation:
/**
* This class is a scanner generated by
* <a href="http://www.jflex.de/";>JFlex</a> 1.5.0-SNAPSHOT
* on 9/16/12 12:10 PM from the specification file
*
<tt>/Users/Erick/apache/4x_4326/lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/HTMLStripCharFilter.jflex</tt>
so I think I have the right jflex, but the tabs still appear in things like
HTMLStripCharFilterFactory. And the files aren't comparable by eyeball, at
least by me. The order of that huge, ugly case statement is different in the
two files, but when I spot-checked a couple of the cases they appear identical.
So I'll try running the silly tests again and disable my troublesome one. If
they pass I'm checking this in unless there are howls of protest.
I'm attaching another pair of files just to insure that what I check in is
exactly what I have on my machine.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch,
> LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch,
> LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch,
> LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author
> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author
> tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
