[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463060#comment-13463060 ]
Robert Muir commented on LUCENE-4426: ------------------------------------- I think the previous patch was done before additional fixed types were added. We could always deprecate the old one (probably should deprecate AND fix it if we do that). Your patch is better (e.g. checks hasArray, etc) from the implementation side. The only thing i dont get is if maybe it really should just be one class like the old one. I dont know why we need Int/Float versions of the classes when these implementations have things like intVal()/floatVal()/doubleVal()... > New ValueSource implementations that wrap DocValues > --------------------------------------------------- > > Key: LUCENE-4426 > URL: https://issues.apache.org/jira/browse/LUCENE-4426 > Project: Lucene - Core > Issue Type: New Feature > Components: modules/other > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Fix For: 4.1, 5.0 > > Attachments: LUCENE-4426.patch > > > We should have ValueSource implementations that wrap DocValues in > lucene-queries so that DocValues can be used in function queries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org