I'm getting this failure:
RuntimeError: JAR file
"/home/projects/lucene_solr_4x/smoke-temp/unpack/lucene-4.0.0/demo/lib/servlet-api-2.4.jar"
contains sheisty class "javax/servlet/Filter.class"
I also tried the patch before it was committed and was getting the same
failure.
I did a fresh checkout of branch_4x after I say this commit go in.
The trace:
unpack lucene-4.0.0.tgz...
make sure JARs don't have javax.* or java.* classes...
Traceback (most recent call last):
File "dev-tools/scripts/smokeTestRelease.py", line 1195, in <module>
File "dev-tools/scripts/smokeTestRelease.py", line 1143, in main
File "dev-tools/scripts/smokeTestRelease.py", line 1178, in smokeTest
File "dev-tools/scripts/smokeTestRelease.py", line 470, in unpack
File "dev-tools/scripts/smokeTestRelease.py", line 580, in verifyUnpacked
File "dev-tools/scripts/smokeTestRelease.py", line 189, in checkAllJARs
File "dev-tools/scripts/smokeTestRelease.py", line 165, in
noJavaPackageClasses
My command line in Cygwin on Windows:
python3.2 -u dev-tools/scripts/smokeTestRelease.py
"http://people.apache.org/~rmuir/staging_area/lucene-solr-4.0RC0-rev1389174/";
4.0.0 smoke-temp
Load release URL
"http://people.apache.org/~rmuir/staging_area/lucene-solr-4.0RC0-rev1389174/";...
-- Jack Krupansky
-----Original Message-----
From: mikemcc...@apache.org
Sent: Wednesday, September 26, 2012 10:52 AM
To: comm...@lucene.apache.org
Subject: svn commit: r1390535 - in /lucene/dev/branches/branch_4x: ./
dev-tools/ dev-tools/scripts/smokeTestRelease.py
Author: mikemccand
Date: Wed Sep 26 14:52:10 2012
New Revision: 1390535
URL: http://svn.apache.org/viewvc?rev=1390535&view=rev
Log:
LUCENE-4430: check for/warn about javax.* and java.* class in any
Lucene/Solr, or dependency JARs
Modified:
lucene/dev/branches/branch_4x/ (props changed)
lucene/dev/branches/branch_4x/dev-tools/ (props changed)
lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
Modified:
lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
URL:
http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py?rev=1390535&r1=1390534&r2=1390535&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
(original)
+++ lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py Wed
Sep 26 14:52:10 2012
@@ -162,17 +162,32 @@ def noJavaPackageClasses(desc, file):
with zipfile.ZipFile(file) as z2:
for name2 in z2.namelist():
if name2.endswith('.class') and (name2.startswith('java/') or
name2.startswith('javax/')):
- raise RuntimeError('%s contains sheisty class "%s"' % \
- (desc, name2))
+ raise RuntimeError('%s contains sheisty class "%s"' % (desc,
name2))
-def checkAllLuceneJARs(root):
- print(' make sure Lucene JARs don\'t have javax.* or java.*
classes...')
- for root, dirs, files in os.walk(root):
+def normSlashes(path):
+ return path.replace(os.sep, '/')
+
+def checkAllJARs(topDir, project):
+ print(' make sure JARs don\'t have javax.* or java.* classes...')
+ for root, dirs, files in os.walk(topDir):
+
+ normRoot = normSlashes(root)
+
+ if project == 'solr' and normRoot.endswith('/example/lib'):
+ # Solr's example intentionally ships servlet JAR:
+ continue
+
for file in files:
if file.lower().endswith('.jar'):
+ if project == 'solr':
+
+ if normRoot.endswith('/contrib/dataimporthandler/lib') and
(file.startswith('mail-') or file.startswith('activation-')):
+ print(' **WARNING**: skipping check of %s/%s: it has
javax.* classes' % (root, file))
+ continue
+
fullPath = '%s/%s' % (root, file)
noJavaPackageClasses('JAR file "%s"' % fullPath, fullPath)
-
+
def checkSolrWAR(warFileName):
"""
@@ -561,8 +576,10 @@ def verifyUnpacked(project, artifact, un
testNotice(unpackPath)
else:
+
+ checkAllJARs(os.getcwd(), project)
+
if project == 'lucene':
- checkAllLuceneJARs(os.getcwd())
testDemo(isSrc, version)
else:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
