We should change the ant target to use the environment variables if they exist.
In the mean time, Jack, just add the following to your ant cmdline: -DJAVA6_HOME="$JAVA6_HOME" -DJAVA7_HOME="$JAVA7_HOME" Steve -----Original Message----- From: Uwe Schindler [mailto:u...@thetaphi.de] Sent: Wednesday, September 26, 2012 1:01 PM To: dev@lucene.apache.org Subject: RE: svn commit: r1390535 - in /lucene/dev/branches/branch_4x: ./ dev-tools/ dev-tools/scripts/smokeTestRelease.py You dont need environment variables, the props must be passed as property to ANT. ----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -----Original Message----- > From: Jack Krupansky [mailto:j...@basetechnology.com] > Sent: Wednesday, September 26, 2012 6:04 PM > To: dev@lucene.apache.org > Subject: Re: svn commit: r1390535 - in /lucene/dev/branches/branch_4x: ./ > dev-tools/ dev-tools/scripts/smokeTestRelease.py > > ant nightly-smoke fails with: > > BUILD FAILED > C:\cygwin\home\projects\lucene_solr_4x\build.xml:264: JAVA6_HOME > property is not defined. > > I do have JAVA6_HOME and JAVA7_HOME environment variables (as the > python code requires and proves). Is there another ant target I need to add or > do I have to manually define ant properties for these as well? > > -- Jack Krupansky > > -----Original Message----- > From: Michael McCandless > Sent: Wednesday, September 26, 2012 11:51 AM > To: dev@lucene.apache.org > Subject: Re: svn commit: r1390535 - in /lucene/dev/branches/branch_4x: ./ > dev-tools/ dev-tools/scripts/smokeTestRelease.py > > That's expected: 4.0 RC0 has the servlet-api under lucene/demo. It's since > been fixed on 4.0.x branch ... > > Try running "ant nightly-smoke" instead? > > Mike McCandless > > http://blog.mikemccandless.com > > > On Wed, Sep 26, 2012 at 11:49 AM, Jack Krupansky > <j...@basetechnology.com> wrote: > > I'm getting this failure: > > > > RuntimeError: JAR file > > "/home/projects/lucene_solr_4x/smoke-temp/unpack/lucene- > 4.0.0/demo/lib/servlet-api-2.4.jar" > > contains sheisty class "javax/servlet/Filter.class" > > > > I also tried the patch before it was committed and was getting the > > same failure. > > > > I did a fresh checkout of branch_4x after I say this commit go in. > > > > The trace: > > > > unpack lucene-4.0.0.tgz... > > > > make sure JARs don't have javax.* or java.* classes... > > Traceback (most recent call last): > > File "dev-tools/scripts/smokeTestRelease.py", line 1195, in <module> > > File "dev-tools/scripts/smokeTestRelease.py", line 1143, in main File > > "dev-tools/scripts/smokeTestRelease.py", line 1178, in smokeTest File > > "dev-tools/scripts/smokeTestRelease.py", line 470, in unpack File > > "dev-tools/scripts/smokeTestRelease.py", line 580, in verifyUnpacked > > File "dev-tools/scripts/smokeTestRelease.py", line 189, in > > checkAllJARs File "dev-tools/scripts/smokeTestRelease.py", line 165, > > in noJavaPackageClasses > > > > My command line in Cygwin on Windows: > > > > python3.2 -u dev-tools/scripts/smokeTestRelease.py > > "http://people.apache.org/~rmuir/staging_area/lucene-solr-4.0RC0- > rev1389174/" > > 4.0.0 smoke-temp > > > > Load release URL > > "http://people.apache.org/~rmuir/staging_area/lucene-solr-4.0RC0- > rev1389174/"... > > > > -- Jack Krupansky > > > > -----Original Message----- From: mikemcc...@apache.org > > Sent: Wednesday, September 26, 2012 10:52 AM > > To: comm...@lucene.apache.org > > Subject: svn commit: r1390535 - in /lucene/dev/branches/branch_4x: ./ > > dev-tools/ dev-tools/scripts/smokeTestRelease.py > > > > > > Author: mikemccand > > Date: Wed Sep 26 14:52:10 2012 > > New Revision: 1390535 > > > > URL: http://svn.apache.org/viewvc?rev=1390535&view=rev > > Log: > > LUCENE-4430: check for/warn about javax.* and java.* class in any > > Lucene/Solr, or dependency JARs > > > > Modified: > > lucene/dev/branches/branch_4x/ (props changed) > > lucene/dev/branches/branch_4x/dev-tools/ (props changed) > > lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py > > > > Modified: > > lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py > > URL: > > http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/dev-tools/s > > > cripts/smokeTestRelease.py?rev=1390535&r1=1390534&r2=1390535&view=dif > f > > > ================================================================ > ====== > > ======== > > --- > > lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py > > (original) > > +++ lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.p > > +++ y > > Wed > > Sep 26 14:52:10 2012 > > @@ -162,17 +162,32 @@ def noJavaPackageClasses(desc, file): > > with zipfile.ZipFile(file) as z2: > > for name2 in z2.namelist(): > > if name2.endswith('.class') and (name2.startswith('java/') or > > name2.startswith('javax/')): > > - raise RuntimeError('%s contains sheisty class "%s"' % \ > > - (desc, name2)) > > + raise RuntimeError('%s contains sheisty class "%s"' % (desc, > > name2)) > > > > -def checkAllLuceneJARs(root): > > - print(' make sure Lucene JARs don\'t have javax.* or java.* > > classes...') > > - for root, dirs, files in os.walk(root): > > +def normSlashes(path): > > + return path.replace(os.sep, '/') > > + > > +def checkAllJARs(topDir, project): > > + print(' make sure JARs don\'t have javax.* or java.* classes...') > > + for root, dirs, files in os.walk(topDir): > > + > > + normRoot = normSlashes(root) > > + > > + if project == 'solr' and normRoot.endswith('/example/lib'): > > + # Solr's example intentionally ships servlet JAR: > > + continue > > + > > for file in files: > > if file.lower().endswith('.jar'): > > + if project == 'solr': > > + > > + if normRoot.endswith('/contrib/dataimporthandler/lib') and > > (file.startswith('mail-') or file.startswith('activation-')): > > + print(' **WARNING**: skipping check of %s/%s: it has > > javax.* classes' % (root, file)) > > + continue > > + > > fullPath = '%s/%s' % (root, file) > > noJavaPackageClasses('JAR file "%s"' % fullPath, fullPath) > > - > > + > > def checkSolrWAR(warFileName): > > > > """ > > @@ -561,8 +576,10 @@ def verifyUnpacked(project, artifact, un > > testNotice(unpackPath) > > > > else: > > + > > + checkAllJARs(os.getcwd(), project) > > + > > if project == 'lucene': > > - checkAllLuceneJARs(os.getcwd()) > > testDemo(isSrc, version) > > > > else: > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For > > additional commands, e-mail: dev-h...@lucene.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional > commands, e-mail: dev-h...@lucene.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional > commands, e-mail: dev-h...@lucene.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
