[
https://issues.apache.org/jira/browse/LUCENE-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469757#comment-13469757
]
Robert Muir commented on LUCENE-4399:
-------------------------------------
{quote}
I started this discussion because I was surprised of the indexVersion ==
version test, but this is a detail, I think it is nice not to seek when it is
not necessary so I am +1 for this patch.
{quote}
Yeah, its a little funky, because of how there is only "one" seekDir, and this
is protected so Appending can subclass it (we can remove this when Appending
goes away).
So that one seekDir (used for both files) needs to know what should happen: I
suppose it could be 'boolean append' or something to be more clear.
I didnt want to have an assert though, or it might invoke Uwe's wrath!
> Rename AppendingCodec to Appending40Codec
> -----------------------------------------
>
> Key: LUCENE-4399
> URL: https://issues.apache.org/jira/browse/LUCENE-4399
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1
>
> Attachments: LUCENE-4399.patch, LUCENE-4399.patch, LUCENE-4399.patch
>
>
> In order AppendingCodec to follow Lucene codecs version, I think its name
> should include a version number (so that, for example, if we get to releave
> Lucene 4.3 with a new Lucene43Codec, there will also be a new
> Appending43Codec).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
