[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475148#comment-13475148 ]
Robert Muir commented on LUCENE-4479: ------------------------------------- Alan this patch looks good. Thanks for tackling this. Do you know off-hand if we have a test anywhere for the case of offsets but NO positions (which there is logic to handle, and looks correct, I'm just curious). > TokenSources.getTokenStream() doesn't return correctly for termvectors with > positions but no offsets > ---------------------------------------------------------------------------------------------------- > > Key: LUCENE-4479 > URL: https://issues.apache.org/jira/browse/LUCENE-4479 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter > Affects Versions: 4.0 > Reporter: Alan Woodward > Priority: Minor > Attachments: LUCENE-4479.patch, LUCENE-4479.patch > > > The javadocs for TokenSources.getTokenStream(Terms, boolean) state: > "Low level api. Returns a token stream or null if no offset info available > in index. This can be used to feed the highlighter with a pre-parsed token > stream" > However, if the Terms instance passed in has positions but no offsets stored, > a TokenStream is incorrectly returned, rather than null. > This has the effect of incorrectly highlighting fields with term vectors and > positions, but no offsets. All highlighting markup is prepended to the > beginning of the field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org