[ https://issues.apache.org/jira/browse/LUCENE-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487249#comment-13487249 ]
Michael McCandless commented on LUCENE-4511: -------------------------------------------- Do we need to check for the "no terms provided" case (throw IAE)? Else we seem to make a TermsAndField w/ null field? Or is that harmless (matches no docs)...? Maybe we need a test for it ... I think the ArrayUtil.grow can be a < not a <=? Should we shrink the byte[] down in the end? Can we rename .terms -> .termBytes? Typo: "don't use case we could pollute the cache here easily" --> "don't use cache since we could pollute the cache here easily" Typo?: "no freq if we don't need them" -> "no freq since we don't need them" Maybe equals should also compare the hashCode first (since we compute/cache it up front)? Should currentTermsAndField be renamed to lastTermsAndField? It's always the last "completed" field right? Hmm I suddenly realized: I think this code is doing the same thing that FrozenBufferedDeletes does (see PrefixCodedTerms ... which takes even fewer bytes since it shares prefixes). Maybe we should just use that? > TermsFilter might return wrong results if a field is not indexed or not > present in the index > -------------------------------------------------------------------------------------------- > > Key: LUCENE-4511 > URL: https://issues.apache.org/jira/browse/LUCENE-4511 > Project: Lucene - Core > Issue Type: Bug > Components: modules/other > Affects Versions: 4.0, 4.1, 5.0 > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Fix For: 4.1, 5.0 > > Attachments: LUCENE-4511.patch, LUCENE-4511.patch, LUCENE-4511.patch, > LUCENE-4511.patch > > > TermsFilter returns if a term returns null from AIR#terms(term) while it > should just continue. I will upload a test & fix shortly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org