[ 
https://issues.apache.org/jira/browse/LUCENE-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487742#comment-13487742
 ] 

Simon Willnauer commented on LUCENE-4511:
-----------------------------------------

bq. Well I suspect TermsFilter is often used with many terms, at which
point prefix coding will usually reduce memory required.

the main point here is reducing # of objects really. In lucene we often focus 
on reducing the memory footprint but even if we don't safe much here we are 
still friendly in terms of GC which is my main concern. so that is also why I 
don't care too much about the prefix coded stuff. Yet we should consolidate 
this. I will open another issue.

bq. Hmm maybe add an explicit test for the "no terms provided" case?
I will add one before I commit. I don't think we should be smart here. Its 
likely a bug if nothing is provided.
                
> TermsFilter might return wrong results if a field is not indexed or not 
> present in the index
> --------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4511
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4511
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/other
>    Affects Versions: 4.0, 4.1, 5.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4511.patch, LUCENE-4511.patch, LUCENE-4511.patch, 
> LUCENE-4511.patch, LUCENE-4511.patch
>
>
> TermsFilter returns if a term returns null from AIR#terms(term) while it 
> should just continue. I will upload a test & fix shortly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to