[
https://issues.apache.org/jira/browse/SOLR-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Per Steffensen updated SOLR-4066:
---------------------------------
Attachment: SOLR-4066.patch
Hi Trym
I believe one of the reasons that they started throwing RuntimeExceptions
insted of UnknownHostException, TimeoutException etc is that the method
signature has changed to not have a "throws"-part. They probably do not want do
deal with those checked exceptions. If they want to keep the method signature
this way, there is no way to get checked excpetions (like UnknownHostException
and TimeoutException) out of this method - therefore the simplest solution is
at least to include the actual exceptions as cause on the RuntimeExceptions -
see patch SOLR-4066.patch. You could tak this patch in as a first solution, and
if it just is an accident that the checked excpetions was removed from the
method signature, then of course you can add them again and make sure the
actual exceptions are thrown correctly.
> SolrZKClient changed interface
> ------------------------------
>
> Key: SOLR-4066
> URL: https://issues.apache.org/jira/browse/SOLR-4066
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.0, 4.0.1, 4.1
> Environment: Any
> Reporter: Trym Møller
> Priority: Minor
> Attachments: SOLR-4066.patch
>
>
> The constructor of SolrZKClient has changed, I expect to ensure clean up of
> resources. The strategy is as follows:
> {code}
> connManager = new ConnectionManager(...)
> try {
> ...
> } catch (Throwable e) {
> connManager.close();
> throw new RuntimeException();
> }
> try {
> connManager.waitForConnected(clientConnectTimeout);
> } catch (Throwable e) {
> connManager.close();
> throw new RuntimeException();
> }
> {code}
> This results in a different exception (RuntimeException) returned from the
> constructor as earlier (nice exceptions as UnknownHostException,
> TimeoutException).
> Can this be changed so we keep the old nice exceptions e.g. as follows
> (requiring the constructor to declare these) or at least include them as
> cause in the RuntimeException?
> {code}
> boolean closeBecauseOfException = true;
> try {
> ...
> connManager.waitForConnected(clientConnectTimeout);
> closeBecauseOfException = false
> } finally {
> if (closeBecauseOfException) {
> connManager.close();
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
