[
https://issues.apache.org/jira/browse/SOLR-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496307#comment-13496307
]
Mark Miller commented on SOLR-4066:
-----------------------------------
Looks like this is a dupe of SOLR-3989? And yonik just committed a fix that
simply adds the exception to the runtimeexception.
Any particular reason we should be more granular here Trym?
> SolrZKClient changed interface
> ------------------------------
>
> Key: SOLR-4066
> URL: https://issues.apache.org/jira/browse/SOLR-4066
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.0, 4.0.1, 4.1
> Environment: Any
> Reporter: Trym Møller
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4066.patch
>
>
> The constructor of SolrZKClient has changed, I expect to ensure clean up of
> resources. The strategy is as follows:
> {code}
> connManager = new ConnectionManager(...)
> try {
> ...
> } catch (Throwable e) {
> connManager.close();
> throw new RuntimeException();
> }
> try {
> connManager.waitForConnected(clientConnectTimeout);
> } catch (Throwable e) {
> connManager.close();
> throw new RuntimeException();
> }
> {code}
> This results in a different exception (RuntimeException) returned from the
> constructor as earlier (nice exceptions as UnknownHostException,
> TimeoutException).
> Can this be changed so we keep the old nice exceptions e.g. as follows
> (requiring the constructor to declare these) or at least include them as
> cause in the RuntimeException?
> {code}
> boolean closeBecauseOfException = true;
> try {
> ...
> connManager.waitForConnected(clientConnectTimeout);
> closeBecauseOfException = false
> } finally {
> if (closeBecauseOfException) {
> connManager.close();
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
