Hi David, there are actually 2 reasons for this check: - It prevents that you forget to add files before committing. We had this quite often, causing unbuildable sources and Jenkins failures. - Prevent test cases from leaving files around at wrong places. This was the original idea behind the task, now obsoleted by the SecurityManager installed by the test-framework. Lots of Solr tests did not set the working directory correctly and started to write files into the src/ (!!!) folder. The check was added, so Jenkins could complain about those problems. This is now solved in a better way, but the check is still good for non-tests. The installed SecurityManager with a very strict security profile prevents wrong-behaving test - a test that writes files outside the build directory will fail with a SecurityException (raised on fileopen with write/append).
Uwe ----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -----Original Message----- > From: David Smiley (@MITRE.org) [mailto:dsmi...@mitre.org] > Sent: Monday, November 26, 2012 3:46 PM > To: dev@lucene.apache.org > Subject: ant precommit; annoyed with "checkout is dirty" > > "ant precommit" will check if the source tree is "dirty" (i.e. contains files > not > in source control) and stop with a failure if so. I find that rather annoying > since I've usually got a variety of .patch files and IDE config changes. > What is > the rationale behind this check? How do people usually deal with it? > Perhaps if I do my real development on another checkout (git based), I could > then patch on the svn one for the commit. Pretty annoying though, and the > 4x port is yet another step. There sure is a lot of burden to getting commits > in. I no longer care to improve little javadoc and typo stuff. > > ~ David > > > > ----- > Author: http://www.packtpub.com/apache-solr-3-enterprise-search- > server/book > -- > View this message in context: http://lucene.472066.n3.nabble.com/ant- > precommit-annoyed-with-checkout-is-dirty-tp4022362.html > Sent from the Lucene - Java Developer mailing list archive at Nabble.com. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional > commands, e-mail: dev-h...@lucene.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
