[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508245#comment-13508245
]
Michael McCandless commented on LUCENE-4575:
--------------------------------------------
I thought we were going to rename ensureOpen's confusing boolean param?
IW.setCommitData should be sync'd I think, eg to ensure visibility
across threads of the changes to sis.userData?
Hmm ... I think there's a thread hazard here, during commit; I think
if pendingCommit is not null you should also call
pendingCommit.setUserData? Else, a commit can finish and "undo" the
user's change to the commit data (see finishCommit, where it calls
.setUserData). Maybe we need a thread safety test
here ...
> Allow IndexWriter to commit, even just commitData
> -------------------------------------------------
>
> Key: LUCENE-4575
> URL: https://issues.apache.org/jira/browse/LUCENE-4575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Shai Erera
> Priority: Minor
> Attachments: LUCENE-4575.patch, LUCENE-4575.patch
>
>
> Spinoff from here
> http://lucene.472066.n3.nabble.com/commit-with-only-commitData-td4022155.html.
> In some cases, it is valuable to be able to commit changes to the index, even
> if the changes are just commitData. Such data is sometimes used by
> applications to register in the index some global application
> information/state.
> The proposal is:
> * Add a setCommitData() API and separate it from commit() and prepareCommit()
> (simplify their API)
> * When that API is called, flip on the dirty/changes bit, so that this gets
> committed even if no other changes were made to the index.
> I will work on a patch a post.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
