[ https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508363#comment-13508363 ]
Shai Erera commented on LUCENE-4575: ------------------------------------ I don't think that we should add more work to finishCommit() either. Being able to setCommitData after prep() is just a bonus. It didn't work before, and it will continue to not work now. And I can't think of a good usecase for why an app would not be able to set commitData prior to prep(). If it comes up, we can discuss a solution again. At least we know that moving commitData write to finishCommit will solve it. I'll make sure the test exposes the bug you reported in IW.finishCommit(). > Allow IndexWriter to commit, even just commitData > ------------------------------------------------- > > Key: LUCENE-4575 > URL: https://issues.apache.org/jira/browse/LUCENE-4575 > Project: Lucene - Core > Issue Type: Improvement > Components: core/index > Reporter: Shai Erera > Priority: Minor > Attachments: LUCENE-4575.patch, LUCENE-4575.patch, > LUCENE-4575-testcase.patch > > > Spinoff from here > http://lucene.472066.n3.nabble.com/commit-with-only-commitData-td4022155.html. > In some cases, it is valuable to be able to commit changes to the index, even > if the changes are just commitData. Such data is sometimes used by > applications to register in the index some global application > information/state. > The proposal is: > * Add a setCommitData() API and separate it from commit() and prepareCommit() > (simplify their API) > * When that API is called, flip on the dirty/changes bit, so that this gets > committed even if no other changes were made to the index. > I will work on a patch a post. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org